Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: webrtc/video_receive_stream.h

Issue 2678343002: Delete VideoReceiveStream::Config::pre_render_callback. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 // Identifier for an A/V synchronization group. Empty string to disable. 172 // Identifier for an A/V synchronization group. Empty string to disable.
173 // TODO(pbos): Synchronize streams in a sync group, not just video streams 173 // TODO(pbos): Synchronize streams in a sync group, not just video streams
174 // to one of the audio streams. 174 // to one of the audio streams.
175 std::string sync_group; 175 std::string sync_group;
176 176
177 // Called for each incoming video frame, i.e. in encoded state. E.g. used 177 // Called for each incoming video frame, i.e. in encoded state. E.g. used
178 // when 178 // when
179 // saving the stream to a file. 'nullptr' disables the callback. 179 // saving the stream to a file. 'nullptr' disables the callback.
180 EncodedFrameObserver* pre_decode_callback = nullptr; 180 EncodedFrameObserver* pre_decode_callback = nullptr;
181 181
182 // Called for each decoded frame. E.g. used when adding effects to the
183 // decoded
184 // stream. 'nullptr' disables the callback.
185 // TODO(tommi): This seems to be only used by a test or two. Consider
186 // removing it (and use an appropriate alternative in the tests) as well
187 // as the associated code in VideoStreamDecoder.
188 I420FrameCallback* pre_render_callback = nullptr;
189
190 // Target delay in milliseconds. A positive value indicates this stream is 182 // Target delay in milliseconds. A positive value indicates this stream is
191 // used for streaming instead of a real-time call. 183 // used for streaming instead of a real-time call.
192 int target_delay_ms = 0; 184 int target_delay_ms = 0;
193 }; 185 };
194 186
195 // Starts stream activity. 187 // Starts stream activity.
196 // When a stream is active, it can receive, process and deliver packets. 188 // When a stream is active, it can receive, process and deliver packets.
197 virtual void Start() = 0; 189 virtual void Start() = 0;
198 // Stops stream activity. 190 // Stops stream activity.
199 // When a stream is stopped, it can't receive, process or deliver packets. 191 // When a stream is stopped, it can't receive, process or deliver packets.
(...skipping 13 matching lines...) Expand all
213 EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0); 205 EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0);
214 } 206 }
215 207
216 protected: 208 protected:
217 virtual ~VideoReceiveStream() {} 209 virtual ~VideoReceiveStream() {}
218 }; 210 };
219 211
220 } // namespace webrtc 212 } // namespace webrtc
221 213
222 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_ 214 #endif // WEBRTC_VIDEO_RECEIVE_STREAM_H_
OLDNEW
« webrtc/video/end_to_end_tests.cc ('K') | « webrtc/video/video_stream_decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698