Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: webrtc/video/video_stream_decoder.h

Issue 2678343002: Delete VideoReceiveStream::Config::pre_render_callback. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 11 matching lines...) Expand all
22 #include "webrtc/media/base/videosinkinterface.h" 22 #include "webrtc/media/base/videosinkinterface.h"
23 #include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimat or.h" 23 #include "webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimat or.h"
24 #include "webrtc/modules/video_coding/include/video_coding_defines.h" 24 #include "webrtc/modules/video_coding/include/video_coding_defines.h"
25 #include "webrtc/typedefs.h" 25 #include "webrtc/typedefs.h"
26 26
27 namespace webrtc { 27 namespace webrtc {
28 28
29 class CallStatsObserver; 29 class CallStatsObserver;
30 class ChannelStatsObserver; 30 class ChannelStatsObserver;
31 class EncodedImageCallback; 31 class EncodedImageCallback;
32 class I420FrameCallback;
33 class ReceiveStatisticsProxy; 32 class ReceiveStatisticsProxy;
34 class VideoRenderCallback; 33 class VideoRenderCallback;
35 34
36 namespace vcm { 35 namespace vcm {
37 class VideoReceiver; 36 class VideoReceiver;
38 } // namespace vcm 37 } // namespace vcm
39 38
40 enum StreamType { 39 enum StreamType {
41 kViEStreamTypeNormal = 0, // Normal media stream 40 kViEStreamTypeNormal = 0, // Normal media stream
42 kViEStreamTypeRtx = 1 // Retransmission media stream 41 kViEStreamTypeRtx = 1 // Retransmission media stream
43 }; 42 };
44 43
45 class VideoStreamDecoder : public VCMReceiveCallback, 44 class VideoStreamDecoder : public VCMReceiveCallback,
46 public VCMReceiveStatisticsCallback, 45 public VCMReceiveStatisticsCallback,
47 public VCMDecoderTimingCallback, 46 public VCMDecoderTimingCallback,
48 public CallStatsObserver { 47 public CallStatsObserver {
49 public: 48 public:
50 friend class ChannelStatsObserver; 49 friend class ChannelStatsObserver;
51 50
52 VideoStreamDecoder(vcm::VideoReceiver* video_receiver, 51 VideoStreamDecoder(
53 VCMFrameTypeCallback* vcm_frame_type_callback, 52 vcm::VideoReceiver* video_receiver,
54 VCMPacketRequestCallback* vcm_packet_request_callback, 53 VCMFrameTypeCallback* vcm_frame_type_callback,
55 bool enable_nack, 54 VCMPacketRequestCallback* vcm_packet_request_callback,
56 bool enable_fec, 55 bool enable_nack,
57 ReceiveStatisticsProxy* receive_statistics_proxy, 56 bool enable_fec,
58 rtc::VideoSinkInterface<VideoFrame>* incoming_video_stream, 57 ReceiveStatisticsProxy* receive_statistics_proxy,
59 I420FrameCallback* pre_render_callback); 58 rtc::VideoSinkInterface<VideoFrame>* incoming_video_stream);
60 ~VideoStreamDecoder(); 59 ~VideoStreamDecoder();
61 60
62 // Implements VCMReceiveCallback. 61 // Implements VCMReceiveCallback.
63 int32_t FrameToRender(VideoFrame& video_frame) override; // NOLINT 62 int32_t FrameToRender(VideoFrame& video_frame) override; // NOLINT
64 int32_t ReceivedDecodedReferenceFrame(const uint64_t picture_id) override; 63 int32_t ReceivedDecodedReferenceFrame(const uint64_t picture_id) override;
65 void OnIncomingPayloadType(int payload_type) override; 64 void OnIncomingPayloadType(int payload_type) override;
66 void OnDecoderImplementationName(const char* implementation_name) override; 65 void OnDecoderImplementationName(const char* implementation_name) override;
67 66
68 // Implements VCMReceiveStatisticsCallback. 67 // Implements VCMReceiveStatisticsCallback.
69 void OnReceiveRatesUpdated(uint32_t bit_rate, uint32_t frame_rate) override; 68 void OnReceiveRatesUpdated(uint32_t bit_rate, uint32_t frame_rate) override;
(...skipping 25 matching lines...) Expand all
95 94
96 private: 95 private:
97 // Used for all registered callbacks except rendering. 96 // Used for all registered callbacks except rendering.
98 rtc::CriticalSection crit_; 97 rtc::CriticalSection crit_;
99 98
100 vcm::VideoReceiver* const video_receiver_; 99 vcm::VideoReceiver* const video_receiver_;
101 100
102 ReceiveStatisticsProxy* const receive_stats_callback_; 101 ReceiveStatisticsProxy* const receive_stats_callback_;
103 rtc::VideoSinkInterface<VideoFrame>* const incoming_video_stream_; 102 rtc::VideoSinkInterface<VideoFrame>* const incoming_video_stream_;
104 103
105 // TODO(tommi): This callback is basically the same thing as the one above.
106 // We shouldn't need to support both.
107 I420FrameCallback* const pre_render_callback_;
108
109 int64_t last_rtt_ms_ GUARDED_BY(crit_); 104 int64_t last_rtt_ms_ GUARDED_BY(crit_);
110 }; 105 };
111 106
112 } // namespace webrtc 107 } // namespace webrtc
113 108
114 #endif // WEBRTC_VIDEO_VIDEO_STREAM_DECODER_H_ 109 #endif // WEBRTC_VIDEO_VIDEO_STREAM_DECODER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698