Allow changing the minimal ICE ping timeout with PeerConnection.SetConfiguration.

webrtc/pc/peerconnectioninterface_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 2203 matching lines @@
   PeerConnectionInterface::RTCConfiguration config;
   config.prune_turn_ports = false;
   CreatePeerConnection(config, nullptr);
   EXPECT_FALSE(port_allocator_->prune_turn_ports());
 
   config.prune_turn_ports = true;
   EXPECT_TRUE(pc_->SetConfiguration(config));
   EXPECT_TRUE(port_allocator_->prune_turn_ports());
 }
 
+// Test that the ice check interval can be changed. This does not verify that
+// the setting makes it all the way to P2PTransportChannel, as that would
+// require a very complex set of mocks.
+TEST_F(PeerConnectionInterfaceTest, SetConfigurationChangesIceCheckInterval) {
+  PeerConnectionInterface::RTCConfiguration config;
+  config.ice_check_min_interval = rtc::Optional<int>();
+  CreatePeerConnection(config, nullptr);
+  config.ice_check_min_interval = rtc::Optional<int>(100);
+  EXPECT_TRUE(pc_->SetConfiguration(config));
+  PeerConnectionInterface::RTCConfiguration new_config =
+      pc_->GetConfiguration();
+  EXPECT_TRUE(new_config.ice_check_min_interval);

[Taylor Brandstetter, 2017/02/03 23:56:17]

nit: ASSERT_TRUE, since the next line will crash if the assertion is false

[skvlad, 2017/02/04 00:01:51]

I'm now comparing it with rtc::Optional<int>(100). Both shorter and safer.

+  EXPECT_EQ(*new_config.ice_check_min_interval, 100);
+}
+
 // Test that when SetConfiguration changes both the pool size and other
 // attributes, the pooled session is created with the updated attributes.
 TEST_F(PeerConnectionInterfaceTest,
        SetConfigurationCreatesPooledSessionCorrectly) {
   CreatePeerConnection();
   PeerConnectionInterface::RTCConfiguration config;
   config.ice_candidate_pool_size = 1;
   PeerConnectionInterface::IceServer server;
   server.uri = kStunAddressOnly;
   config.servers.push_back(server);
@@ skipping 1147 matching lines @@
   EXPECT_NE(a, f);
 
   PeerConnectionInterface::RTCConfiguration g;
   g.disable_ipv6 = true;
   EXPECT_NE(a, g);
 
   PeerConnectionInterface::RTCConfiguration h(
       PeerConnectionInterface::RTCConfigurationType::kAggressive);
   EXPECT_NE(a, h);
 }