Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: webrtc/call/call_perf_tests.cc

Issue 2676973004: Fix KeepsHighBitrateWhenReconfiguringSender to avoid flakiness if probing succeeds in between encod… (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call_perf_tests.cc
diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc
index b6a8fe6047070f50d4f0ba2b4e887f5251c93024..e52d967ed4a9a5921acf5f49866e528e4edcdfe1 100644
--- a/webrtc/call/call_perf_tests.cc
+++ b/webrtc/call/call_perf_tests.cc
@@ -663,8 +663,9 @@ TEST_F(CallPerfTest, KeepsHighBitrateWhenReconfiguringSender) {
EXPECT_EQ(2 * kDefaultWidth, config->width);
EXPECT_EQ(2 * kDefaultHeight, config->height);
EXPECT_GE(last_set_bitrate_kbps_, kReconfigureThresholdKbps);
- EXPECT_NEAR(config->startBitrate, last_set_bitrate_kbps_,
- kPermittedReconfiguredBitrateDiffKbps)
+ EXPECT_GT(
+ config->startBitrate,
+ last_set_bitrate_kbps_ - kPermittedReconfiguredBitrateDiffKbps)
<< "Encoder reconfigured with bitrate too far away from last set.";
observation_complete_.Set();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698