Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2675943002: RTCInboundRTPStreamStats.qpSum collected. (Closed)
Patch Set: Removed set timestamp, moved default testing so that a test case could be removed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/rtcstats_integrationtest.cc
diff --git a/webrtc/pc/rtcstats_integrationtest.cc b/webrtc/pc/rtcstats_integrationtest.cc
index 577504728786c476bad527e76bb3c54921859feb..26d45ed879e55f4bbc0313961c5b3c002dd9c184 100644
--- a/webrtc/pc/rtcstats_integrationtest.cc
+++ b/webrtc/pc/rtcstats_integrationtest.cc
@@ -525,7 +525,15 @@ class RTCStatsReportVerifier {
const RTCInboundRTPStreamStats& inbound_stream) {
RTCStatsVerifier verifier(report_, &inbound_stream);
VerifyRTCRTPStreamStats(inbound_stream, &verifier);
- verifier.TestMemberIsUndefined(inbound_stream.qp_sum);
+ // TODO(hbos): As soon as the encoders provide |qp_sum| values, this
+ // if-statement needs to be included.
hta-webrtc 2017/02/07 12:19:41 Nit: Since this is the incoming stream, it's the d
hbos 2017/02/07 15:37:04 Done.
+ // https://bugs.chromium.org/p/webrtc/issues/detail?id=7065
+ // if (inbound_stream.media_type.is_defined() &&
+ // *inbound_stream.media_type == "video") {
+ // verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.qp_sum);
+ // } else {
+ verifier.TestMemberIsUndefined(inbound_stream.qp_sum);
+ // }
verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received);
verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received);
verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost);

Powered by Google App Engine
This is Rietveld 408576698