RTCInboundRTPStreamStats.qpSum collected.

webrtc/pc/rtcstats_integrationtest.cc

 /*
  *  Copyright 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 507 matching lines @@
       verifier->TestMemberIsUndefined(stream.pli_count);
       verifier->TestMemberIsUndefined(stream.nack_count);
     }
     verifier->TestMemberIsUndefined(stream.sli_count);
   }
 
   bool VerifyRTCInboundRTPStreamStats(
       const RTCInboundRTPStreamStats& inbound_stream) {
     RTCStatsVerifier verifier(report_, &inbound_stream);
     VerifyRTCRTPStreamStats(inbound_stream, &verifier);
-    verifier.TestMemberIsUndefined(inbound_stream.qp_sum);
+    // TODO(hbos): As soon as the encoders provide |qp_sum| values, this
+    // if-statement needs to be included.

[hta-webrtc, 2017/02/07 12:19:41]

Nit: Since this is the incoming stream, it's the decoder, not the encoder that
needs to provide the value.

Writing it like this is good, since it will trigger an error the first time
someone actually provides a value in test.

[hbos, 2017/02/07 15:37:04]

Done.

+    // https://bugs.chromium.org/p/webrtc/issues/detail?id=7065
+    // if (inbound_stream.media_type.is_defined() &&
+    //     *inbound_stream.media_type == "video") {
+    //   verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.qp_sum);
+    // } else {
+      verifier.TestMemberIsUndefined(inbound_stream.qp_sum);
+    // }
     verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_received);
     verifier.TestMemberIsNonNegative<uint64_t>(inbound_stream.bytes_received);
     verifier.TestMemberIsNonNegative<uint32_t>(inbound_stream.packets_lost);
     if (inbound_stream.media_type.is_defined() &&
         *inbound_stream.media_type == "video") {
       verifier.TestMemberIsUndefined(inbound_stream.jitter);
     } else {
       verifier.TestMemberIsNonNegative<double>(inbound_stream.jitter);
     }
     verifier.TestMemberIsNonNegative<double>(inbound_stream.fraction_lost);
@@ skipping 86 matching lines @@
   caller_ = nullptr;
   // Any pending stats requests should have completed in the act of destroying
   // the peer connection.
   EXPECT_TRUE(stats_obtainer->report());
 }
 #endif  // HAVE_SCTP
 
 }  // namespace
 
 }  // namespace webrtc