Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: webrtc/pc/peerconnection.cc

Issue 2675173003: Adding "adapter" ORTC objects on top of ChannelManager/BaseChannel/etc. (Closed)
Patch Set: Some comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/peerconnection.cc
diff --git a/webrtc/pc/peerconnection.cc b/webrtc/pc/peerconnection.cc
index 96e2b339a49d25faa32e449b2944c362b27c946a..c3ec0b2aad903839cc4e03340254903299d9524a 100644
--- a/webrtc/pc/peerconnection.cc
+++ b/webrtc/pc/peerconnection.cc
@@ -458,27 +458,6 @@ bool SafeSetError(webrtc::RTCErrorType type, webrtc::RTCError* error) {
namespace webrtc {
-static const char* const kRTCErrorTypeNames[] = {
- "NONE",
- "UNSUPPORTED_PARAMETER",
- "INVALID_PARAMETER",
- "INVALID_RANGE",
- "SYNTAX_ERROR",
- "INVALID_STATE",
- "INVALID_MODIFICATION",
- "NETWORK_ERROR",
- "INTERNAL_ERROR",
-};
-static_assert(static_cast<int>(RTCErrorType::INTERNAL_ERROR) ==
- (arraysize(kRTCErrorTypeNames) - 1),
- "kRTCErrorTypeNames must have as many strings as RTCErrorType "
- "has values.");
-
-std::ostream& operator<<(std::ostream& stream, RTCErrorType error) {
- int index = static_cast<int>(error);
- return stream << kRTCErrorTypeNames[index];
-}
-
bool PeerConnectionInterface::RTCConfiguration::operator==(
const PeerConnectionInterface::RTCConfiguration& o) const {
// This static_assert prevents us from accidentally breaking operator==.
@@ -1636,9 +1615,10 @@ void PeerConnection::CreateAudioReceiver(MediaStreamInterface* stream,
uint32_t ssrc) {
rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>
receiver = RtpReceiverProxyWithInternal<RtpReceiverInternal>::Create(
- signaling_thread(), new AudioRtpReceiver(stream, track_id, ssrc,
- session_->voice_channel()));
-
+ signaling_thread(),
+ new AudioRtpReceiver(track_id, ssrc, session_->voice_channel()));
+ stream->AddTrack(
+ static_cast<AudioTrackInterface*>(receiver->internal()->track().get()));
receivers_.push_back(receiver);
std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams;
streams.push_back(rtc::scoped_refptr<MediaStreamInterface>(stream));
@@ -1651,8 +1631,10 @@ void PeerConnection::CreateVideoReceiver(MediaStreamInterface* stream,
rtc::scoped_refptr<RtpReceiverProxyWithInternal<RtpReceiverInternal>>
receiver = RtpReceiverProxyWithInternal<RtpReceiverInternal>::Create(
signaling_thread(),
- new VideoRtpReceiver(stream, track_id, factory_->worker_thread(),
- ssrc, session_->video_channel()));
+ new VideoRtpReceiver(track_id, factory_->worker_thread(), ssrc,
+ session_->video_channel()));
+ stream->AddTrack(
+ static_cast<VideoTrackInterface*>(receiver->internal()->track().get()));
receivers_.push_back(receiver);
std::vector<rtc::scoped_refptr<MediaStreamInterface>> streams;
streams.push_back(rtc::scoped_refptr<MediaStreamInterface>(stream));

Powered by Google App Engine
This is Rietveld 408576698