Adding "adapter" ORTC objects on top of ChannelManager/BaseChannel/etc.

webrtc/media/sctp/sctptransport.h

Index: webrtc/media/sctp/sctptransport.h
diff --git a/webrtc/media/sctp/sctptransport.h b/webrtc/media/sctp/sctptransport.h
index 2f2746c48b9d2494e3e36d6784187404840f27e1..b34db80c3b407fb0bb4b37c46e8486147a022bc0 100644
--- a/webrtc/media/sctp/sctptransport.h
+++ b/webrtc/media/sctp/sctptransport.h
@@ -67,11 +67,11 @@ class SctpTransport : public SctpTransportInternal,
   // methods can be called.
   // |channel| is required (must not be null).
   SctpTransport(rtc::Thread* network_thread,
-                rtc::PacketTransportInterface* channel);
+                rtc::PacketTransportInternal* channel);

[pthatcher1, 2017/02/08 01:33:49]

Why does an SctpTransport need the internal version?

[Taylor Brandstetter, 2017/02/10 00:19:45]

Because it uses it to send and receive packets, and receive events. Or, do you
mean, why does it not take a PacketTransportInterface and call GetInternal()?
Because that's not necessary anywhere yet.

   ~SctpTransport() override;
 
   // SctpTransportInternal overrides (see sctptransportinternal.h for comments).
-  void SetTransportChannel(rtc::PacketTransportInterface* channel) override;
+  void SetTransportChannel(rtc::PacketTransportInternal* channel) override;
   bool Start(int local_port, int remote_port) override;
   bool OpenStream(int sid) override;
   bool ResetStream(int sid) override;
@@ -108,8 +108,8 @@ class SctpTransport : public SctpTransportInternal,
   void SetReadyToSendData();
 
   // Callbacks from DTLS channel.
-  void OnWritableState(rtc::PacketTransportInterface* transport);
-  virtual void OnPacketRead(rtc::PacketTransportInterface* transport,
+  void OnWritableState(rtc::PacketTransportInternal* transport);
+  virtual void OnPacketRead(rtc::PacketTransportInternal* transport,
                             const char* data,
                             size_t len,
                             const rtc::PacketTime& packet_time,
@@ -140,7 +140,7 @@ class SctpTransport : public SctpTransportInternal,
   // Helps pass inbound/outbound packets asynchronously to the network thread.
   rtc::AsyncInvoker invoker_;
   // Underlying DTLS channel.
-  rtc::PacketTransportInterface* transport_channel_;
+  rtc::PacketTransportInternal* transport_channel_;
   bool was_ever_writable_ = false;
   int local_port_ = kSctpDefaultPort;
   int remote_port_ = kSctpDefaultPort;
@@ -179,7 +179,7 @@ class SctpTransportFactory : public SctpTransportInternalFactory {
       : network_thread_(network_thread) {}
 
   std::unique_ptr<SctpTransportInternal> CreateSctpTransport(
-      rtc::PacketTransportInterface* channel) override {
+      rtc::PacketTransportInternal* channel) override {
     return std::unique_ptr<SctpTransportInternal>(
         new SctpTransport(network_thread_, channel));
   }