Adding "adapter" ORTC objects on top of ChannelManager/BaseChannel/etc.

webrtc/api/ortc/rtptransportcontrollerinterface.h

+/*
+ *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_API_ORTC_RTPTRANSPORTCONTROLLERINTERFACE_H_
+#define WEBRTC_API_ORTC_RTPTRANSPORTCONTROLLERINTERFACE_H_
+
+#include <vector>
+
+#include "webrtc/api/ortc/rtptransportinterface.h"
+
+namespace webrtc {
+
+class RtpTransportControllerShim;

[pthatcher1, 2017/02/10 22:36:52]

Can you leave a comment somewhere about what "shim" means and how it's temporary
and should go away?  Just one place would be enough, although a "see the comment
in this other place" would be nice to sprinkle around a bit.

[Taylor Brandstetter, 2017/02/14 06:55:04]

This is just a forward declaration. I have a comment explaining it in each
header file for the object itself. Also, I renamed to "adapter" since that's
more commonly used terminology.

+
+// Used to group RTP transports to the same remote endpoint, for the purpose of
+// sharing bandwidth estimation and other things. Comparing this to the
+// PeerConnection model, non-budled audio/video would use two RtpTransports
+// with a single RtpTransportController, whereas bundled media would use a
+// single RtpTransport.
+//
+// RtpTransports are associated with this controller when they're created, by
+// passing the controller into OrtcFactory's relevant "CreateRtpTransport"
+// method. When a transport is destroyed, it's automatically disassociated.
+// GetTransports returns all currently associated transports.
+//
+// This is the RTP equivalent of "IceTransportController" in ORTC; RtpTransport
+// is to RtpTransportController as IceTransport is to IceTransportController.
+class RtpTransportControllerInterface {
+ public:
+  virtual ~RtpTransportControllerInterface() {}
+
+  // Returns all transports that are controlled by this controller and
+  // haven't yet been destroyed.
+  virtual std::vector<RtpTransportInterface*> GetTransports() const = 0;
+
+ protected:
+  // Only for internal use.
+  // Returns a pointer to the internal (non-public) interface.
+  virtual RtpTransportControllerShim* GetInternal() = 0;
+
+  // Classes that can use this internal interface.
+  friend class RtpTransportShim;
+};
+
+}  // namespace webrtc
+
+#endif  // WEBRTC_API_ORTC_RTPTRANSPORTCONTROLLERINTERFACE_H_