Adding "adapter" ORTC objects on top of ChannelManager/BaseChannel/etc.

webrtc/media/sctp/sctptransport.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 49 matching lines @@
 //  SctpTransport are called with the recieved data]
 // TODO(zhihuang): Rename "channel" to "transport" on network-level.
 class SctpTransport : public SctpTransportInternal,
                       public sigslot::has_slots<> {
  public:
   // |network_thread| is where packets will be processed and callbacks from
   // this transport will be posted, and is the only thread on which public
   // methods can be called.
   // |channel| is required (must not be null).
   SctpTransport(rtc::Thread* network_thread,
-                rtc::PacketTransportInterface* channel);
+                rtc::PacketTransportInternal* channel);

[pthatcher1, 2017/02/08 01:33:49]

Why does an SctpTransport need the internal version?

[Taylor Brandstetter, 2017/02/10 00:19:45]

Because it uses it to send and receive packets, and receive events. Or, do you
mean, why does it not take a PacketTransportInterface and call GetInternal()?
Because that's not necessary anywhere yet.

   ~SctpTransport() override;
 
   // SctpTransportInternal overrides (see sctptransportinternal.h for comments).
-  void SetTransportChannel(rtc::PacketTransportInterface* channel) override;
+  void SetTransportChannel(rtc::PacketTransportInternal* channel) override;
   bool Start(int local_port, int remote_port) override;
   bool OpenStream(int sid) override;
   bool ResetStream(int sid) override;
   bool SendData(const SendDataParams& params,
                 const rtc::CopyOnWriteBuffer& payload,
                 SendDataResult* result = nullptr) override;
   bool ReadyToSendData() override;
   void set_debug_name_for_testing(const char* debug_name) override {
     debug_name_ = debug_name;
   }
@@ skipping 16 matching lines @@
   // Sets |sock_ |to nullptr.
   void CloseSctpSocket();
 
   // Sends a SCTP_RESET_STREAM for all streams in closing_ssids_.
   bool SendQueuedStreamResets();
 
   // Sets the "ready to send" flag and fires signal if needed.
   void SetReadyToSendData();
 
   // Callbacks from DTLS channel.
-  void OnWritableState(rtc::PacketTransportInterface* transport);
-  virtual void OnPacketRead(rtc::PacketTransportInterface* transport,
+  void OnWritableState(rtc::PacketTransportInternal* transport);
+  virtual void OnPacketRead(rtc::PacketTransportInternal* transport,
                             const char* data,
                             size_t len,
                             const rtc::PacketTime& packet_time,
                             int flags);
 
   // Methods related to usrsctp callbacks.
   void OnSendThresholdCallback();
   sockaddr_conn GetSctpSockAddr(int port);
 
   // Called using |invoker_| to send packet on the network.
@@ skipping 10 matching lines @@
   void OnNotificationAssocChange(const sctp_assoc_change& change);
 
   void OnStreamResetEvent(const struct sctp_stream_reset_event* evt);
 
   // Responsible for marshalling incoming data to the channels listeners, and
   // outgoing data to the network interface.
   rtc::Thread* network_thread_;
   // Helps pass inbound/outbound packets asynchronously to the network thread.
   rtc::AsyncInvoker invoker_;
   // Underlying DTLS channel.
-  rtc::PacketTransportInterface* transport_channel_;
+  rtc::PacketTransportInternal* transport_channel_;
   bool was_ever_writable_ = false;
   int local_port_ = kSctpDefaultPort;
   int remote_port_ = kSctpDefaultPort;
   struct socket* sock_ = nullptr;  // The socket created by usrsctp_socket(...).
 
   // Has Start been called? Don't create SCTP socket until it has.
   bool started_ = false;
   // Are we ready to queue data (SCTP socket created, and not blocked due to
   // congestion control)? Different than |transport_channel_|'s "ready to
   // send".
@@ skipping 18 matching lines @@
 
   RTC_DISALLOW_COPY_AND_ASSIGN(SctpTransport);
 };
 
 class SctpTransportFactory : public SctpTransportInternalFactory {
  public:
   explicit SctpTransportFactory(rtc::Thread* network_thread)
       : network_thread_(network_thread) {}
 
   std::unique_ptr<SctpTransportInternal> CreateSctpTransport(
-      rtc::PacketTransportInterface* channel) override {
+      rtc::PacketTransportInternal* channel) override {
     return std::unique_ptr<SctpTransportInternal>(
         new SctpTransport(network_thread_, channel));
   }
 
  private:
   rtc::Thread* network_thread_;
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_MEDIA_SCTP_SCTPTRANSPORT_H_