webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h - Issue 2672933003: Introduce FecControllerRplrBased

Side by Side Diff: webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.h

Issue 2672933003: Introduce FecControllerRplrBased (Closed)

Patch Set: Merged Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/fec_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 /*

2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.

3 *

4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.

9 */

10

11 #ifndef WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_FEC_CONTROLLER_H_

12 #define WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_FEC_CONTROLLER_H_

13

14 #include <memory>

15

16 #include "webrtc/base/constructormagic.h"

17 #include "webrtc/common_audio/smoothing_filter.h"

18 #include "webrtc/modules/audio_coding/audio_network_adaptor/controller.h"

19

20 namespace webrtc {

21

22 class FecController final : public Controller {

23 public:

24 struct Config {

25 struct Threshold {

26 // Threshold defines a curve in the bandwidth/packet-loss domain. The

27 // curve is characterized by the two conjunction points: A and B.

28 //

29 // packet ^ \|

30 // loss \| A\|

31 // \| \ A: (low_bandwidth_bps, low_bandwidth_packet_loss)

32 // \| \ B: (high_bandwidth_bps, high_bandwidth_packet_loss)

33 // \| B\________

34 // \|---------------> bandwidth

35 Threshold(int low_bandwidth_bps,

36 float low_bandwidth_packet_loss,

37 int high_bandwidth_bps,

38 float high_bandwidth_packet_loss);

39 int low_bandwidth_bps;

40 float low_bandwidth_packet_loss;

41 int high_bandwidth_bps;

42 float high_bandwidth_packet_loss;

43 };

44

45 // \|fec_enabling_threshold\| defines a curve, above which FEC should be

46 // enabled. \|fec_disabling_threshold\| defines a curve, under which FEC

47 // should be disabled. See below

48 //

49 // packet-loss ^ \| \|

50 // \| \| \| FEC

51 // \| \ \ ON

52 // \| FEC \ \_______ fec_enabling_threshold

53 // \| OFF \_________ fec_disabling_threshold

54 // \|-----------------> bandwidth

55 Config(bool initial_fec_enabled,

56 const Threshold& fec_enabling_threshold,

57 const Threshold& fec_disabling_threshold,

58 int time_constant_ms,

59 const Clock* clock);

60 bool initial_fec_enabled;

61 Threshold fec_enabling_threshold;

62 Threshold fec_disabling_threshold;

63 int time_constant_ms;

64 const Clock* clock;

65 };

66

67 // Dependency injection for testing.

68 FecController(const Config& config,

69 std::unique_ptr<SmoothingFilter> smoothing_filter);

70

71 explicit FecController(const Config& config);

72

73 ~FecController() override;

74

75 void UpdateNetworkMetrics(const NetworkMetrics& network_metrics) override;

76

77 void MakeDecision(AudioNetworkAdaptor::EncoderRuntimeConfig* config) override;

78

79 private:

80 // Characterize Threshold with packet_loss = slope * bandwidth + offset.

81 struct ThresholdInfo {

82 explicit ThresholdInfo(const Config::Threshold& threshold);

83 float slope;

84 float offset;

85 };

86

87 float GetPacketLossThreshold(int bandwidth_bps,

88 const Config::Threshold& threshold,

89 const ThresholdInfo& threshold_info) const;

90

91 bool FecEnablingDecision(const rtc::Optional<float>& packet_loss) const;

92 bool FecDisablingDecision(const rtc::Optional<float>& packet_loss) const;

93

94 const Config config_;

95 bool fec_enabled_;

96 rtc::Optional<int> uplink_bandwidth_bps_;

97 const std::unique_ptr<SmoothingFilter> packet_loss_smoother_;

98

99 const ThresholdInfo fec_enabling_threshold_info_;

100 const ThresholdInfo fec_disabling_threshold_info_;

101

102 RTC_DISALLOW_COPY_AND_ASSIGN(FecController);

103 };

104

105 } // namespace webrtc

106

107 #endif // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_FEC_CONTROLLER_H_

OLD	NEW