Don't capture variables explicitly in lambda expression.

webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc

Index: webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
index 71893e50174853d17e00876582c81f7a9d53df7d..726aa03ad7b3075289e30882c1c04c145962bfda 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc
@@ -313,9 +313,8 @@ TEST_F(NetEqImplTest, InsertPacket) {
   rtc::scoped_refptr<MockAudioDecoderFactory> mock_decoder_factory(
       new rtc::RefCountedObject<MockAudioDecoderFactory>);
   EXPECT_CALL(*mock_decoder_factory, MakeAudioDecoderMock(_, _))
-      .WillOnce(Invoke([kPayloadLength, kFirstSequenceNumber, kFirstTimestamp,
-                        kFirstReceiveTime](const SdpAudioFormat& format,
-                                           std::unique_ptr<AudioDecoder>* dec) {
+      .WillOnce(Invoke([=](const SdpAudioFormat& format,
+                          std::unique_ptr<AudioDecoder>* dec) {

[kwiberg-webrtc, 2017/02/02 18:24:59]

Uh? I clearly see those constants being used a bit further down in the lambda
body... whatever compiler you're using must be confused.

However. If you must make a default capture, it's probably better to capture by
reference. Otherwise, it's very hard to see exactly what sort of copy
constructors end up being called.

(Yes, that means the lambda must not be called after the end of the block in
which it was created, but that is the case here. If it weren't the case, I would
have objected to default capturing, by reference OR by value.)

[ossu, 2017/02/06 14:20:51]

If I were to guess as to why this happens, it's the compiler replacing constants
with literal values in the lambda body and only afterwards checking for
unnecessary captures. Very strange. Sounds like a compiler bug. Which compiler
does this? GCC? MSVC?

         EXPECT_EQ("pcmu", format.name);
 
         std::unique_ptr<MockAudioDecoder> mock_decoder(new MockAudioDecoder);