Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: webrtc/media/base/videobroadcaster_unittest.cc

Issue 2672793002: Change rtc::VideoSinkWants to have target and a max pixel count (Closed)
Patch Set: Fixed incorrect behavior in VideoAdapter, updated test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/base/videobroadcaster_unittest.cc
diff --git a/webrtc/media/base/videobroadcaster_unittest.cc b/webrtc/media/base/videobroadcaster_unittest.cc
index 30a678b1c159839da664f33545f43cb3533662a3..5274868204589856369a9a1a46a9b41c68c37b7c 100644
--- a/webrtc/media/base/videobroadcaster_unittest.cc
+++ b/webrtc/media/base/videobroadcaster_unittest.cc
@@ -106,25 +106,25 @@ TEST(VideoBroadcasterTest, AppliesMinOfSinkWantsMaxPixelCount) {
EXPECT_EQ(1280 * 720, *broadcaster.wants().max_pixel_count);
}
-TEST(VideoBroadcasterTest, AppliesMinOfSinkWantsMaxPixelCountStepUp) {
+TEST(VideoBroadcasterTest, AppliesMinOfSinkWantsMaxAndTargetPixelCount) {
VideoBroadcaster broadcaster;
- EXPECT_TRUE(!broadcaster.wants().max_pixel_count_step_up);
+ EXPECT_TRUE(!broadcaster.wants().target_pixel_count);
FakeVideoRenderer sink1;
VideoSinkWants wants1;
- wants1.max_pixel_count_step_up = rtc::Optional<int>(1280 * 720);
+ wants1.target_pixel_count = rtc::Optional<int>(1280 * 720);
broadcaster.AddOrUpdateSink(&sink1, wants1);
- EXPECT_EQ(1280 * 720, *broadcaster.wants().max_pixel_count_step_up);
+ EXPECT_EQ(1280 * 720, *broadcaster.wants().target_pixel_count);
FakeVideoRenderer sink2;
VideoSinkWants wants2;
- wants2.max_pixel_count_step_up = rtc::Optional<int>(640 * 360);
+ wants2.target_pixel_count = rtc::Optional<int>(640 * 360);
broadcaster.AddOrUpdateSink(&sink2, wants2);
- EXPECT_EQ(640 * 360, *broadcaster.wants().max_pixel_count_step_up);
+ EXPECT_EQ(640 * 360, *broadcaster.wants().target_pixel_count);
broadcaster.RemoveSink(&sink2);
- EXPECT_EQ(1280 * 720, *broadcaster.wants().max_pixel_count_step_up);
+ EXPECT_EQ(1280 * 720, *broadcaster.wants().target_pixel_count);
}
TEST(VideoBroadcasterTest, SinkWantsBlackFrames) {

Powered by Google App Engine
This is Rietveld 408576698