Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2671903002: Revert of Pick the DTLS handshake timeout based on the ICE RTT estimate (Closed)

Created:
3 years, 10 months ago by skvlad
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Pick the DTLS handshake timeout based on the ICE RTT estimate (patchset #3 id:40001 of https://codereview.webrtc.org/2670113002/ ) Reason for revert: Breaks Chromium FYI bots. Original issue's description: > Pick the DTLS handshake timeout based on the ICE RTT estimate > > This CL replaces the previously-hardcoded DTLS timeout value of 50 ms with one that is picked dynamically as 2x ICE RTT (clamped between 50 and 3000 ms to keep it reasonable). > > No tests yet - I'm working on these, but sending out this CL early to get feedback. I've tested it manually and on slow networks it results in successful DTLS setup in a single attempt - instead of clogging up the slow link with multiple retransmissions as done previosly. > > BUG=webrtc:7099 > > Review-Url: https://codereview.webrtc.org/2670113002 > Cr-Commit-Position: refs/heads/master@{#16426} > Committed: https://chromium.googlesource.com/external/webrtc/+/d030912de4d49e247533892927819c4a7f055815 TBR=deadbeef@webrtc.org,pthatcher@webrtc.org,pthatcher@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -69 lines) Patch
M webrtc/base/opensslstreamadapter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/base/sslstreamadapter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M webrtc/p2p/base/fakeicetransport.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/p2p/base/icetransportinternal.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/port.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
skvlad
Created Revert of Pick the DTLS handshake timeout based on the ICE RTT estimate
3 years, 10 months ago (2017-02-03 01:37:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2671903002/1
3 years, 10 months ago (2017-02-03 01:37:31 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 01:37:32 UTC) #5
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698