Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1531)

Unified Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2670343002: Refactor and clean-up relating to RTCCodecStats. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/pc/rtcstatscollector.cc » ('j') | webrtc/pc/rtcstatscollector.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/stats/rtcstats_objects.h
diff --git a/webrtc/api/stats/rtcstats_objects.h b/webrtc/api/stats/rtcstats_objects.h
index ac00386370d04b5f7f4d3973d45b596c96ae7aa3..6c24d67b63fb894cedee6540d2a72b1d695454a9 100644
--- a/webrtc/api/stats/rtcstats_objects.h
+++ b/webrtc/api/stats/rtcstats_objects.h
@@ -77,9 +77,6 @@ class RTCCertificateStats final : public RTCStats {
};
// https://w3c.github.io/webrtc-stats/#codec-dict*
-// Tracking bug crbug.com/659117
-// TODO(hbos): The present codec ID assignment is not sufficient to support
-// Unified Plan or unbundled connections in all cases. crbug.com/659117
class RTCCodecStats final : public RTCStats {
public:
WEBRTC_RTCSTATS_DECL();
@@ -92,11 +89,11 @@ class RTCCodecStats final : public RTCStats {
RTCStatsMember<uint32_t> payload_type;
RTCStatsMember<std::string> codec;
RTCStatsMember<uint32_t> clock_rate;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+ // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
RTCStatsMember<uint32_t> channels;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+ // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
RTCStatsMember<std::string> parameters;
- // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117
+ // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
RTCStatsMember<std::string> implementation;
};
« no previous file with comments | « no previous file | webrtc/pc/rtcstatscollector.cc » ('j') | webrtc/pc/rtcstatscollector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698