Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2670343002: Refactor and clean-up relating to RTCCodecStats. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/pc/rtcstatscollector.cc » ('j') | webrtc/pc/rtcstatscollector.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 RTCCertificateStats(const RTCCertificateStats& other); 70 RTCCertificateStats(const RTCCertificateStats& other);
71 ~RTCCertificateStats() override; 71 ~RTCCertificateStats() override;
72 72
73 RTCStatsMember<std::string> fingerprint; 73 RTCStatsMember<std::string> fingerprint;
74 RTCStatsMember<std::string> fingerprint_algorithm; 74 RTCStatsMember<std::string> fingerprint_algorithm;
75 RTCStatsMember<std::string> base64_certificate; 75 RTCStatsMember<std::string> base64_certificate;
76 RTCStatsMember<std::string> issuer_certificate_id; 76 RTCStatsMember<std::string> issuer_certificate_id;
77 }; 77 };
78 78
79 // https://w3c.github.io/webrtc-stats/#codec-dict* 79 // https://w3c.github.io/webrtc-stats/#codec-dict*
80 // Tracking bug crbug.com/659117
81 // TODO(hbos): The present codec ID assignment is not sufficient to support
82 // Unified Plan or unbundled connections in all cases. crbug.com/659117
83 class RTCCodecStats final : public RTCStats { 80 class RTCCodecStats final : public RTCStats {
84 public: 81 public:
85 WEBRTC_RTCSTATS_DECL(); 82 WEBRTC_RTCSTATS_DECL();
86 83
87 RTCCodecStats(const std::string& id, int64_t timestamp_us); 84 RTCCodecStats(const std::string& id, int64_t timestamp_us);
88 RTCCodecStats(std::string&& id, int64_t timestamp_us); 85 RTCCodecStats(std::string&& id, int64_t timestamp_us);
89 RTCCodecStats(const RTCCodecStats& other); 86 RTCCodecStats(const RTCCodecStats& other);
90 ~RTCCodecStats() override; 87 ~RTCCodecStats() override;
91 88
92 RTCStatsMember<uint32_t> payload_type; 89 RTCStatsMember<uint32_t> payload_type;
93 RTCStatsMember<std::string> codec; 90 RTCStatsMember<std::string> codec;
94 RTCStatsMember<uint32_t> clock_rate; 91 RTCStatsMember<uint32_t> clock_rate;
95 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117 92 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
96 RTCStatsMember<uint32_t> channels; 93 RTCStatsMember<uint32_t> channels;
97 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117 94 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
98 RTCStatsMember<std::string> parameters; 95 RTCStatsMember<std::string> parameters;
99 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/659117 96 // TODO(hbos): Collect and populate this value. https://bugs.webrtc.org/7061
100 RTCStatsMember<std::string> implementation; 97 RTCStatsMember<std::string> implementation;
101 }; 98 };
102 99
103 // https://w3c.github.io/webrtc-stats/#dcstats-dict* 100 // https://w3c.github.io/webrtc-stats/#dcstats-dict*
104 class RTCDataChannelStats final : public RTCStats { 101 class RTCDataChannelStats final : public RTCStats {
105 public: 102 public:
106 WEBRTC_RTCSTATS_DECL(); 103 WEBRTC_RTCSTATS_DECL();
107 104
108 RTCDataChannelStats(const std::string& id, int64_t timestamp_us); 105 RTCDataChannelStats(const std::string& id, int64_t timestamp_us);
109 RTCDataChannelStats(std::string&& id, int64_t timestamp_us); 106 RTCDataChannelStats(std::string&& id, int64_t timestamp_us);
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"? 409 // TODO(hbos): Support enum types? "RTCStatsMember<RTCDtlsTransportState>"?
413 RTCStatsMember<std::string> dtls_state; 410 RTCStatsMember<std::string> dtls_state;
414 RTCStatsMember<std::string> selected_candidate_pair_id; 411 RTCStatsMember<std::string> selected_candidate_pair_id;
415 RTCStatsMember<std::string> local_certificate_id; 412 RTCStatsMember<std::string> local_certificate_id;
416 RTCStatsMember<std::string> remote_certificate_id; 413 RTCStatsMember<std::string> remote_certificate_id;
417 }; 414 };
418 415
419 } // namespace webrtc 416 } // namespace webrtc
420 417
421 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 418 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/pc/rtcstatscollector.cc » ('j') | webrtc/pc/rtcstatscollector.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698