Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: webrtc/base/sslstreamadapter.h

Issue 2670113002: Pick the DTLS handshake timeout based on the ICE RTT estimate (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/sslstreamadapter.h
diff --git a/webrtc/base/sslstreamadapter.h b/webrtc/base/sslstreamadapter.h
index 4f5ee02fe44343fb7028e5f9ca354a371ff50d9d..b4f577ae2add967cfe8776ebca75ce823ee496fd 100644
--- a/webrtc/base/sslstreamadapter.h
+++ b/webrtc/base/sslstreamadapter.h
@@ -156,6 +156,11 @@ class SSLStreamAdapter : public StreamAdapterInterface {
// next lower will be used.
virtual void SetMaxProtocolVersion(SSLProtocolVersion version) = 0;
+ // Set the initial timeout for the handshake message. When the timeout
+ // expires, the handshake message gets retransmitted and the timeout is
+ // exponentially increased.
+ virtual void SetHandshakeTimeout(int timeout_ms) = 0;
Taylor Brandstetter 2017/02/02 18:07:41 nit: Better name would be "InitialRetransmissionTi
pthatcher2 2017/02/02 20:09:44 +1
skvlad 2017/02/02 22:19:33 I made it InitialHandshakeRetransmissionTimeout. L
Taylor Brandstetter 2017/02/02 22:57:27 I'd still call it just "InitialRetransmissionTimeo
+
// StartSSL starts negotiation with a peer, whose certificate is verified
// using the certificate digest. Generally, SetIdentity() and possibly
// SetServerRole() should have been called before this.

Powered by Google App Engine
This is Rietveld 408576698