Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.cc

Issue 2669583002: Added a flag to AudioCodecSpec to indicate adaptive bitrate support. (Closed)
Patch Set: int -> size_t to avoid unsigned/signed mismatch warnings on Windows. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine.cc
diff --git a/webrtc/media/engine/webrtcvoiceengine.cc b/webrtc/media/engine/webrtcvoiceengine.cc
index 2db552611220775e67f4f82a936ec949d2b01934..b07e9bb5db7339b55666b92a358d1f01913040cb 100644
--- a/webrtc/media/engine/webrtcvoiceengine.cc
+++ b/webrtc/media/engine/webrtcvoiceengine.cc
@@ -1166,26 +1166,30 @@ AudioCodecs WebRtcVoiceEngine::CollectRecvCodecs() const {
{ 32000, false },
{ 48000, false }};
- auto map_format = [&mapper, &out] (const webrtc::SdpAudioFormat& format) {
+ auto map_format = [&mapper](const webrtc::SdpAudioFormat& format,
+ AudioCodecs* out) {
rtc::Optional<AudioCodec> opt_codec = mapper.ToAudioCodec(format);
- if (!opt_codec) {
+ if (opt_codec) {
+ if (out) {
+ out->push_back(*opt_codec);
+ }
+ } else {
LOG(LS_ERROR) << "Unable to assign payload type to format: " << format;
- return false;
}
- auto& codec = *opt_codec;
- if (IsCodec(codec, kOpusCodecName)) {
- // TODO(ossu): Set this specifically for Opus for now, until we have a
- // better way of dealing with rtcp-fb parameters.
- codec.AddFeedbackParam(
- FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
- }
- out.push_back(codec);
- return true;
+ return opt_codec;
};
for (const auto& spec : specs) {
- if (map_format(spec.format)) {
+ // We need to do some extra stuff before adding the main codecs to out.
+ rtc::Optional<AudioCodec> opt_codec = map_format(spec.format, nullptr);
+ if (opt_codec) {
+ AudioCodec& codec = *opt_codec;
+ if (spec.supports_network_adaption) {
+ codec.AddFeedbackParam(
+ FeedbackParam(kRtcpFbParamTransportCc, kParamValueEmpty));
+ }
+
if (spec.allow_comfort_noise) {
// Generate a CN entry if the decoder allows it and we support the
// clockrate.
@@ -1200,20 +1204,22 @@ AudioCodecs WebRtcVoiceEngine::CollectRecvCodecs() const {
if (dtmf != generate_dtmf.end()) {
dtmf->second = true;
}
+
+ out.push_back(codec);
}
}
// Add CN codecs after "proper" audio codecs.
for (const auto& cn : generate_cn) {
if (cn.second) {
- map_format({kCnCodecName, cn.first, 1});
+ map_format({kCnCodecName, cn.first, 1}, &out);
}
}
// Add telephone-event codecs last.
for (const auto& dtmf : generate_dtmf) {
if (dtmf.second) {
- map_format({kDtmfCodecName, dtmf.first, 1});
+ map_format({kDtmfCodecName, dtmf.first, 1}, &out);
}
}
« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('j') | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698