Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Side by Side Diff: webrtc/api/DEPS

Issue 2668523004: Move AudioDecoder and related stuff to the api/ directory (Closed)
Patch Set: sort #includes + git cl format Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 "+third_party/libyuv", 2 "+third_party/libyuv",
3 "+webrtc/base", 3 "+webrtc/base",
4 "+webrtc/common_video", 4 "+webrtc/common_video",
5 "+webrtc/media", 5 "+webrtc/media",
6 "+webrtc/p2p", 6 "+webrtc/p2p",
7 "+webrtc/pc", 7 "+webrtc/pc",
8 ] 8 ]
9 9
10 specific_include_rules = { 10 specific_include_rules = {
11 "peerconnection_jni\.cc": [ 11 "peerconnection_jni\.cc": [
12 "+webrtc/voice_engine", 12 "+webrtc/voice_engine",
13 ], 13 ],
14 14
15 # TODO(kwiberg): Remove this exception when audio_decoder_factory.h 15 # We allow .cc files in webrtc/api/ to #include a bunch of stuff
kjellander_webrtc 2017/02/01 14:54:50 Which are the cases for this? It sounds like those
kwiberg-webrtc 2017/02/01 20:15:02 Files in api/ must be allowed to include files out
ossu 2017/02/06 12:54:16 Yeah, if api/ is to be the one and only external a
kjellander_webrtc 2017/02/10 07:58:48 Thanks for explaining. Let's do this.
16 # has moved to api/. 16 # that's off-limits for the .h files. That's because .h files leak
17 "peerconnectioninterface\.h": [ 17 # their #includes to whoever's #including them, but .cc files do not
18 "+webrtc/modules/audio_coding/codecs/audio_decoder_factory.h", 18 # since no one #includes them.
19 ".*\.cc": [
20 "+webrtc/modules/audio_coding",
19 ], 21 ],
20 } 22 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698