crash with ASAN and libjingle in WebRTC thread

crash with ASAN and libjingle in WebRTC thread

Fix a crash on thread completion due to incorect calling convention on
Windows.

R=henrike@webrtc.org
BUG=chromium:687251

[etienneb, 2017-01-31 19:08:07]

Description was changed from

==========
crash with ASAN and libjingle in WebRTC thread

Fix a crash on thread completion due to incorect calling convention on
Wondows.

BUG=chromium:687251
==========

to

==========
crash with ASAN and libjingle in WebRTC thread

Fix a crash on thread completion due to incorect calling convention on
Windows.

R=henrike@webrtc.org
BUG=chromium:687251
==========

[etienneb, 2017-01-31 19:08:08]

etienneb@chromium.org changed reviewers:
+ henrike@webrtc.org, rnk@chromium.org

[etienneb, 2017-01-31 19:09:40]

PTAL & CQ or modify/land

I do not have a standalone repo for WebRTC.

[Reid Kleckner, 2017-01-31 19:20:43]

lgtm, looks like the right fix to me.

This is the third or so time we've run into this issue. I added
-Wcast-calling-convention to clang specifically to catch this issue. I'll see
why it's not firing.

[Reid Kleckner, 2017-01-31 19:51:30]

I fixed -Wcast-calling-convention to find this bug in clang r293677. We may need
to do some cleanup, but hopefully not too much.

[hans, 2017-02-01 16:55:51]

hans@chromium.org changed reviewers:
+ hans@chromium.org, henrika@chromium.org, kwiberg@chromium.org,
niklase@chromium.org

[hans, 2017-02-01 16:55:52]

With rnk's warning, our bots are now red due to this.

+More WebRTC people: Can any of you stamp this?

[niklas.enbom, 2017-02-01 17:00:33]

lgtm
On 2017/02/01 16:55:52, hans wrote:
> With rnk's warning, our bots are now red due to this.
> 
> +More WebRTC people: Can any of you stamp this?

[hans, 2017-02-01 17:02:25]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2017-02-01 17:02:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-01 17:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 17:04:01]

Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/16861)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/22293)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21035)

[Nico, 2017-02-01 17:09:35]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-02-01 17:09:36]

Patch failure can happen if you make an webrtc patch from within a chromium
repo. If you haven't, you need to create a standalone webrtc checkout
(documented on the webrtc website, just run `fetch webrtc` in empty Dir iirc)
and upload the patch from there.

https://codereview.webrtc.org/2667863003/diff/1/webrtc/base/thread.cc
File webrtc/base/thread.cc (left):

https://codereview.webrtc.org/2667863003/diff/1/webrtc/base/thread.cc#oldcode232
webrtc/base/thread.cc:232: &thread_id_);
You can remove this cast now, right?

[etienneb, 2017-02-01 17:54:00]

closing this issue

landed here:
https://codereview.webrtc.org/2668693005/