Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log.proto

Issue 2666533002: Add probe logging to RtcEventLog. (Closed)
Patch Set: |min_probes| --> |min_packets| Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log.proto
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.proto b/webrtc/logging/rtc_event_log/rtc_event_log.proto
index e80772297997ce2b088404d8ff83395b71fab4f8..e1d726e8608b623025393deee5a84b22407f7ef3 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log.proto
+++ b/webrtc/logging/rtc_event_log/rtc_event_log.proto
@@ -38,6 +38,8 @@ message Event {
AUDIO_RECEIVER_CONFIG_EVENT = 10;
AUDIO_SENDER_CONFIG_EVENT = 11;
AUDIO_NETWORK_ADAPTATION_EVENT = 16;
+ BWE_PROBE_CLUSTER_CREATED_EVENT = 17;
+ BWE_PROBE_RESULT_EVENT = 18;
}
// required - Indicates the type of this event
@@ -69,6 +71,12 @@ message Event {
// optional - but required if type == AUDIO_NETWORK_ADAPTATION_EVENT
optional AudioNetworkAdaptation audio_network_adaptation = 16;
+
+ // optional - but required if type == BWE_PROBE_CLUSTER_CREATED_EVENT
+ optional BweProbeCluster probe_cluster = 17;
+
+ // optional - but required if type == BWE_PROBE_RESULT_EVENT
+ optional BweProbeResult probe_result = 18;
}
message RtpPacket {
@@ -84,6 +92,9 @@ message RtpPacket {
// required - The RTP header only.
optional bytes header = 4;
+ // optional - The probe cluster id.
+ optional uint32 probe_cluster_id = 5;
+
// Do not add code to log user payload data without a privacy review!
}
@@ -251,4 +262,36 @@ message AudioNetworkAdaptation {
// Number of audio channels that each encoded packet consists of.
optional uint32 num_channels = 6;
+}
+
+message BweProbeCluster {
+ // required - The id of this probe cluster.
+ optional uint32 id = 1;
+
+ // required - The bitrate in bps that this probe cluster is meant to probe.
+ optional uint64 bitrate_bps = 2;
+
+ // required - The minimum number of packets used to probe the given bitrate.
+ optional uint32 min_packets = 3;
+
+ // required - The minimum number of bytes used to probe the given bitrate.
+ optional uint32 min_bytes = 4;
+}
+
+message BweProbeResult {
+ // required - The id of this probe cluster.
+ optional uint32 id = 1;
+
+ enum ResultType {
+ SUCCESS = 0;
+ INVALID_SEND_RECEIVE_INTERVAL = 1;
+ INVALID_SEND_RECEIVE_RATIO = 2;
+ TIMEOUT = 3;
+ }
+
+ // required - The result of this probing attempt.
+ optional ResultType result = 2;
+
+ // optional - but required if result == SUCCESS. The resulting bitrate in bps.
+ optional uint64 bitrate_bps = 3;
}

Powered by Google App Engine
This is Rietveld 408576698