Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc |
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc |
index cc7af559d077b1d0e4bdf6f9ded4af9e0b25af3b..24c5f1311ef02f4263861fbd131bc1a3ffd09d53 100644 |
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc |
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc |
@@ -101,12 +101,6 @@ |
EXPECT_TRUE(it != rtx_types.end() && |
it->second == config.rtp.ulpfec.red_rtx_payload_type); |
} |
-} |
- |
-cricket::MediaConfig GetMediaConfig() { |
- cricket::MediaConfig media_config; |
- media_config.video.enable_cpu_overuse_detection = false; |
- return media_config; |
} |
} // namespace |
@@ -336,7 +330,7 @@ |
TEST_F(WebRtcVideoEngine2Test, SetSendFailsBeforeSettingCodecs) { |
engine_.Init(); |
std::unique_ptr<VideoMediaChannel> channel( |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions())); |
EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123))); |
@@ -349,7 +343,7 @@ |
TEST_F(WebRtcVideoEngine2Test, GetStatsWithoutSendCodecsSetDoesNotCrash) { |
engine_.Init(); |
std::unique_ptr<VideoMediaChannel> channel( |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions())); |
EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123))); |
VideoMediaInfo info; |
channel->GetStats(&info); |
@@ -444,7 +438,7 @@ |
} else { |
engine_.Init(); |
channel.reset( |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions())); |
} |
ASSERT_TRUE( |
channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc))); |
@@ -554,7 +548,7 @@ |
engine_.Init(); |
VideoMediaChannel* channel = |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions()); |
cricket::VideoSendParameters parameters; |
// We need to look up the codec in the engine to get the correct payload type. |
for (const VideoCodec& codec : encoder_factory->supported_codecs()) |
@@ -572,7 +566,7 @@ |
engine_.Init(); |
VideoMediaChannel* channel = |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions()); |
cricket::VideoRecvParameters parameters; |
parameters.codecs = codecs; |
EXPECT_TRUE(channel->SetRecvParameters(parameters)); |
@@ -645,7 +639,7 @@ |
engine_.Init(); |
std::unique_ptr<VideoMediaChannel> channel( |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions())); |
cricket::VideoSendParameters parameters; |
parameters.codecs.push_back(GetEngineCodec("VP8")); |
EXPECT_TRUE(channel->SetSendParameters(parameters)); |
@@ -666,7 +660,7 @@ |
engine_.Init(); |
std::unique_ptr<VideoMediaChannel> channel( |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions())); |
cricket::VideoSendParameters parameters; |
parameters.codecs.push_back(GetEngineCodec("VP8")); |
EXPECT_TRUE(channel->SetSendParameters(parameters)); |
@@ -706,7 +700,7 @@ |
engine_.Init(); |
std::unique_ptr<VideoMediaChannel> channel( |
- engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(call_.get(), MediaConfig(), VideoOptions())); |
cricket::VideoSendParameters parameters; |
parameters.codecs.push_back(GetEngineCodec("H264")); |
EXPECT_TRUE(channel->SetSendParameters(parameters)); |
@@ -969,8 +963,8 @@ |
void SetUp() override { |
fake_call_.reset(new FakeCall(webrtc::Call::Config(&event_log_))); |
engine_.Init(); |
- channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(), |
- VideoOptions())); |
+ channel_.reset( |
+ engine_.CreateChannel(fake_call_.get(), MediaConfig(), VideoOptions())); |
channel_->OnReadyToSend(true); |
last_ssrc_ = 123; |
send_parameters_.codecs = engine_.codecs(); |
@@ -1781,7 +1775,7 @@ |
} |
TEST_F(WebRtcVideoChannel2Test, SetMediaConfigSuspendBelowMinBitrate) { |
- MediaConfig media_config = GetMediaConfig(); |
+ MediaConfig media_config = MediaConfig(); |
media_config.video.suspend_below_min_bitrate = true; |
channel_.reset( |
@@ -2078,7 +2072,7 @@ |
cricket::VideoSendParameters parameters; |
parameters.codecs.push_back(codec); |
- MediaConfig media_config = GetMediaConfig(); |
+ MediaConfig media_config = MediaConfig(); |
channel_.reset( |
engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions())); |
channel_->OnReadyToSend(true); |
@@ -2153,8 +2147,7 @@ |
cricket::VideoSendParameters parameters; |
parameters.codecs.push_back(codec); |
- MediaConfig media_config = GetMediaConfig(); |
- media_config.video.enable_cpu_overuse_detection = true; |
+ MediaConfig media_config = MediaConfig(); |
channel_.reset( |
engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions())); |
channel_->OnReadyToSend(true); |
@@ -2219,9 +2212,9 @@ |
cricket::VideoSendParameters parameters; |
parameters.codecs.push_back(codec); |
- MediaConfig media_config = GetMediaConfig(); |
- if (enable_overuse) { |
- media_config.video.enable_cpu_overuse_detection = true; |
+ MediaConfig media_config = MediaConfig(); |
+ if (!enable_overuse) { |
+ media_config.video.enable_cpu_overuse_detection = false; |
} |
channel_.reset( |
engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions())); |
@@ -3947,7 +3940,7 @@ |
void SetUp() override { |
engine_.Init(); |
channel_.reset( |
- engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions())); |
+ engine_.CreateChannel(&fake_call_, MediaConfig(), VideoOptions())); |
channel_->OnReadyToSend(true); |
last_ssrc_ = 123; |
} |