Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Side by Side Diff: webrtc/voice_engine/shared_data.cc

Issue 2665693002: Moves channel-dependent audio input processing to separate encoder task queue (Closed)
Patch Set: Final feedback from Fredrik Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/voice_engine/shared_data.h" 11 #include "webrtc/voice_engine/shared_data.h"
12 12
13 #include "webrtc/modules/audio_processing/include/audio_processing.h" 13 #include "webrtc/modules/audio_processing/include/audio_processing.h"
14 #include "webrtc/system_wrappers/include/trace.h" 14 #include "webrtc/system_wrappers/include/trace.h"
15 #include "webrtc/voice_engine/channel.h" 15 #include "webrtc/voice_engine/channel.h"
16 #include "webrtc/voice_engine/output_mixer.h" 16 #include "webrtc/voice_engine/output_mixer.h"
17 #include "webrtc/voice_engine/transmit_mixer.h" 17 #include "webrtc/voice_engine/transmit_mixer.h"
18 18
19 namespace webrtc { 19 namespace webrtc {
20 20
21 namespace voe { 21 namespace voe {
22 22
23 static int32_t _gInstanceCounter = 0; 23 static int32_t _gInstanceCounter = 0;
24 24
25 SharedData::SharedData() 25 SharedData::SharedData()
26 : _instanceId(++_gInstanceCounter), 26 : _instanceId(++_gInstanceCounter),
27 _channelManager(_gInstanceCounter), 27 _channelManager(_gInstanceCounter),
28 _engineStatistics(_gInstanceCounter), 28 _engineStatistics(_gInstanceCounter),
29 _audioDevicePtr(NULL), 29 _audioDevicePtr(NULL),
30 _moduleProcessThreadPtr( 30 _moduleProcessThreadPtr(ProcessThread::Create("VoiceProcessThread")),
31 ProcessThread::Create("VoiceProcessThread")) { 31 encoder_queue_("AudioEncoderQueue") {
32 Trace::CreateTrace(); 32 Trace::CreateTrace();
33 if (OutputMixer::Create(_outputMixerPtr, _gInstanceCounter) == 0) 33 if (OutputMixer::Create(_outputMixerPtr, _gInstanceCounter) == 0) {
34 { 34 _outputMixerPtr->SetEngineInformation(_engineStatistics);
35 _outputMixerPtr->SetEngineInformation(_engineStatistics); 35 }
36 } 36 if (TransmitMixer::Create(_transmitMixerPtr, _gInstanceCounter) == 0) {
37 if (TransmitMixer::Create(_transmitMixerPtr, _gInstanceCounter) == 0) 37 _transmitMixerPtr->SetEngineInformation(*_moduleProcessThreadPtr,
38 { 38 _engineStatistics, _channelManager);
39 _transmitMixerPtr->SetEngineInformation(*_moduleProcessThreadPtr, 39 }
40 _engineStatistics,
41 _channelManager);
42 }
43 } 40 }
44 41
45 SharedData::~SharedData() 42 SharedData::~SharedData()
46 { 43 {
47 OutputMixer::Destroy(_outputMixerPtr); 44 OutputMixer::Destroy(_outputMixerPtr);
48 TransmitMixer::Destroy(_transmitMixerPtr); 45 TransmitMixer::Destroy(_transmitMixerPtr);
49 if (_audioDevicePtr) { 46 if (_audioDevicePtr) {
50 _audioDevicePtr->Release(); 47 _audioDevicePtr->Release();
51 } 48 }
52 _moduleProcessThreadPtr->Stop(); 49 _moduleProcessThreadPtr->Stop();
53 Trace::ReturnTrace(); 50 Trace::ReturnTrace();
54 } 51 }
55 52
53 rtc::TaskQueue* SharedData::encoder_queue() {
54 RTC_DCHECK_RUN_ON(&construction_thread_);
55 return &encoder_queue_;
56 }
57
56 void SharedData::set_audio_device( 58 void SharedData::set_audio_device(
57 const rtc::scoped_refptr<AudioDeviceModule>& audio_device) { 59 const rtc::scoped_refptr<AudioDeviceModule>& audio_device) {
58 _audioDevicePtr = audio_device; 60 _audioDevicePtr = audio_device;
59 } 61 }
60 62
61 void SharedData::set_audio_processing(AudioProcessing* audioproc) { 63 void SharedData::set_audio_processing(AudioProcessing* audioproc) {
62 audioproc_.reset(audioproc); 64 audioproc_.reset(audioproc);
63 _transmitMixerPtr->SetAudioProcessingModule(audioproc); 65 _transmitMixerPtr->SetAudioProcessingModule(audioproc);
64 _outputMixerPtr->SetAudioProcessingModule(audioproc); 66 _outputMixerPtr->SetAudioProcessingModule(audioproc);
65 } 67 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 } 102 }
101 103
102 void SharedData::SetLastError(int32_t error, TraceLevel level, 104 void SharedData::SetLastError(int32_t error, TraceLevel level,
103 const char* msg) const { 105 const char* msg) const {
104 _engineStatistics.SetLastError(error, level, msg); 106 _engineStatistics.SetLastError(error, level, msg);
105 } 107 }
106 108
107 } // namespace voe 109 } // namespace voe
108 110
109 } // namespace webrtc 111 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698