Moves channel-dependent audio input processing to separate encoder task queue

webrtc/voice_engine/shared_data.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/voice_engine/shared_data.h"
 
 #include "webrtc/modules/audio_processing/include/audio_processing.h"
 #include "webrtc/system_wrappers/include/trace.h"
 #include "webrtc/voice_engine/channel.h"
 #include "webrtc/voice_engine/output_mixer.h"
 #include "webrtc/voice_engine/transmit_mixer.h"
 
+#include "webrtc/base/logging.h"
+
 namespace webrtc {
 
 namespace voe {
 
 static int32_t _gInstanceCounter = 0;
 
 SharedData::SharedData()
     : _instanceId(++_gInstanceCounter),
       _channelManager(_gInstanceCounter),
       _engineStatistics(_gInstanceCounter),
       _audioDevicePtr(NULL),
-      _moduleProcessThreadPtr(
-          ProcessThread::Create("VoiceProcessThread")) {
-    Trace::CreateTrace();
-    if (OutputMixer::Create(_outputMixerPtr, _gInstanceCounter) == 0)
-    {
-        _outputMixerPtr->SetEngineInformation(_engineStatistics);
-    }
-    if (TransmitMixer::Create(_transmitMixerPtr, _gInstanceCounter) == 0)
-    {
-        _transmitMixerPtr->SetEngineInformation(*_moduleProcessThreadPtr,
-                                                _engineStatistics,
-                                                _channelManager);
-    }
+      _moduleProcessThreadPtr(ProcessThread::Create("VoiceProcessThread")),
+      encoder_queue_("AudioEncoderQueue", rtc::TaskQueue::Priority::HIGH) {

[tommi, 2017/03/28 13:47:20]

why high priority?  This doesn't work btw on Android or in Chrome.

[henrika_webrtc, 2017/03/29 10:35:12]

Encoding is important and it sounded like a suitable feature I could use. Let me
answer with a question: when is is suitable to use?

I will remove usage in this CL.

+  Trace::CreateTrace();
+  if (OutputMixer::Create(_outputMixerPtr, _gInstanceCounter) == 0) {
+    _outputMixerPtr->SetEngineInformation(_engineStatistics);
+  }
+  if (TransmitMixer::Create(_transmitMixerPtr, _gInstanceCounter) == 0) {
+    _transmitMixerPtr->SetEngineInformation(*_moduleProcessThreadPtr,
+                                            _engineStatistics, _channelManager);
+  }
 }
 
 SharedData::~SharedData()
 {
     OutputMixer::Destroy(_outputMixerPtr);
     TransmitMixer::Destroy(_transmitMixerPtr);
     if (_audioDevicePtr) {
         _audioDevicePtr->Release();
     }
     _moduleProcessThreadPtr->Stop();
@@ skipping 47 matching lines @@
 }
 
 void SharedData::SetLastError(int32_t error, TraceLevel level,
                               const char* msg) const {
   _engineStatistics.SetLastError(error, level, msg);
 }
 
 }  // namespace voe
 
 }  // namespace webrtc