Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: webrtc/p2p/base/stun.h

Issue 2665343002: Change StunMessage::AddAttribute return type from bool to void. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/stun.h
diff --git a/webrtc/p2p/base/stun.h b/webrtc/p2p/base/stun.h
index 153f63dc58665ef3a9322c7c2fb292f0b3e8b17b..028787c72aa9fd80c985bf156182803b221edcce 100644
--- a/webrtc/p2p/base/stun.h
+++ b/webrtc/p2p/base/stun.h
@@ -158,10 +158,8 @@ class StunMessage {
const StunErrorCodeAttribute* GetErrorCode() const;
const StunUInt16ListAttribute* GetUnknownAttributes() const;
- // Takes ownership of the specified attribute, verifies it is of the correct
- // type, and adds it to the message. The return value indicates whether this
- // was successful.
- bool AddAttribute(StunAttribute* attr);
+ // Takes ownership of the specified attribute and adds it to the message.
+ void AddAttribute(StunAttribute* attr);
// Validates that a raw STUN message has a correct MESSAGE-INTEGRITY value.
// This can't currently be done on a StunMessage, since it is affected by
« no previous file with comments | « webrtc/p2p/base/relayport.cc ('k') | webrtc/p2p/base/stun.cc » ('j') | webrtc/p2p/base/stun.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698