webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java - Issue 2662273004: Remove NewApi lint suppression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java

Issue 2662273004: Remove NewApi lint suppression. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java ('k') | webrtc/sdk/android/instrumentationtests/src/org/webrtc/FileVideoCapturerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java

diff --git a/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java b/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java

index ca37dfe495658190bdb57a27b186f26b5216d4c2..4a45187a58d792454749010401403d32d44a15b6 100644

--- a/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java

+++ b/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java

@@ -284,6 +284,7 @@ public class WebRtcAudioTrack {

+ "max gain: " + audioTrack.getMaxVolume());

}

+ @TargetApi(24)

private void logMainParametersExtended() {

if (WebRtcAudioUtils.runningOnMarshmallowOrHigher()) {

Logging.d(TAG, "AudioTrack: "

@@ -303,6 +304,7 @@ public class WebRtcAudioTrack {

// potential audio glitch.

// TODO(henrika): keep track of this value in the field and possibly add new

// UMA stat if needed.

+ @TargetApi(24)

private void logUnderrunCount() {

if (WebRtcAudioUtils.runningOnNougatOrHigher()) {

Logging.d(TAG, "underrun count: " + audioTrack.getUnderrunCount());