Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc

Issue 2661043003: Allow ANA to receive RPLR (recoverable packet loss rate) indications (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc
diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc
index 7770e65a269ec8e246d982e647f9ad3bc2d23f23..4acf777de021ce00704e3ea88a3226280767a683 100644
--- a/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc
+++ b/webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc
@@ -94,6 +94,13 @@ void DebugDumpWriterImpl::DumpNetworkMetrics(
if (metrics.rtt_ms)
dump_metrics->set_rtt_ms(*metrics.rtt_ms);
+ // TODO(elad.alon): Before landing - is there a dump-reading tool in the
elad.alon_webrtc.org 2017/03/16 19:01:37 michaelt@, that's parse_ana_dump.py, right? Has it
michaelt 2017/03/20 09:17:23 The Cl for parse_ana_dump.py is uploaded and wait
elad.alon_webrtc.org 2017/03/20 18:54:05 Cool, thanks.
+ // codebase, which we can now update? Or does it only exist on people drives?
+ if (metrics.uplink_recoverable_packet_loss_fraction) {
+ dump_metrics->set_uplink_recoverable_packet_loss_fraction(
+ *metrics.uplink_recoverable_packet_loss_fraction);
+ }
+
DumpEventToFile(event, dump_file_.get());
#endif // WEBRTC_AUDIO_NETWORK_ADAPTOR_DEBUG_DUMP
}

Powered by Google App Engine
This is Rietveld 408576698