Allow ANA to receive RPLR (recoverable packet loss rate) indications

webrtc/audio/audio_send_stream.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/audio/audio_send_stream.h"
 
 #include <string>
+#include <vector>
 
 #include "webrtc/audio/audio_state.h"
 #include "webrtc/audio/conversion.h"
 #include "webrtc/audio/scoped_voe_interface.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/base/event.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/task_queue.h"
 #include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
 #include "webrtc/modules/congestion_controller/include/send_side_congestion_controller.h"
@@ skipping 243 matching lines @@
     // potentially reset the window, setting both PLR and RPLR to unknown.
   }
 }
 
 void AudioSendStream::OnNewTransportFeedbackVector(
     const std::vector<PacketFeedback>& packet_feedback_vector) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   rtc::CritScope lock(&packet_loss_tracker_cs_);
   packet_loss_tracker_.OnNewTransportFeedbackVector(packet_feedback_vector);
   const auto plr = packet_loss_tracker_.GetPacketLossRate();
+  const auto rplr = packet_loss_tracker_.GetRecoverablePacketLossRate();
   // TODO(elad.alon): Resolve the following known issue - if PLR goes back

[ossu, 2017/03/22 13:41:18]

I guess you've considered this: it looks like at least the RPLR is gotten as an
Optional, then stripped and sent along as a float only to eventually be put back
into an Optional. Sending an Optional all the way would give you a way to
invalidate the measurement.

Not going to insist on that here, though. I believe hooking up directly to the
encoder is still the way to go.

[elad.alon_webrtc.org, 2017/03/22 15:15:55]

I did consider it - even had a CL for it
(https://codereview.webrtc.org/2746333009/) - but after both online and offline
discussion, had to abandon it and place this TODO here instead, for future
handling.

   // to unknown, no indication is given that the previously sent value is no
   // longer relevant. This will be taken care of with some refactoring which is
   // now being done.
   if (plr) {
     channel_proxy_->OnTwccBasedUplinkPacketLossRate(*plr);
   }
+  if (rplr) {

[stefan-webrtc, 2017/03/22 12:15:46]

Can plr and rplr be active simultaneously? Should we comment on why and how that
works? Maybe it's handled somewhere else

[minyue-webrtc, 2017/03/22 12:17:36]

Yes, plr will be used for frame length adaptation etc, rplr mainly for FEC
tuning.

[elad.alon_webrtc.org, 2017/03/22 15:15:55]

I'm not sure what comment would make things clearer. I mean, they are two
separate metrics, after all. Minyue has given a good example with the
controllers. I'll add that the values might even theoretically be used by
something other than ANA, once it's passed to Channel. Is there a specific
comment you'd recommend?

+    channel_proxy_->OnRecoverableUplinkPacketLossRate(*rplr);
+  }
 }
 
 const webrtc::AudioSendStream::Config& AudioSendStream::config() const {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   return config_;
 }
 
 void AudioSendStream::SetTransportOverhead(int transport_overhead_per_packet) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   send_side_cc_->SetTransportOverhead(transport_overhead_per_packet);
@@ skipping 115 matching lines @@
         LOG(LS_WARNING) << "SetVADStatus() failed.";
         return false;
       }
     }
   }
   return true;
 }
 
 }  // namespace internal
 }  // namespace webrtc