Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2660253002: Do not regenerate ssrc on SetSendingStatus (Closed)

Created:
3 years, 10 months ago by danilchap
Modified:
3 years, 10 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Do not regenerate ssrc on SetSendingStatus That feature is obsolete (rtp module shouldn't be reused between calls), but confuse rtp module in some audio tests. BUG=webrtc:6887

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (6 generated)
danilchap
The CQ bit was checked by danilchap@webrtc.org to run a CQ dry run
3 years, 10 months ago (2017-01-30 17:20:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2660253002/1
3 years, 10 months ago (2017-01-30 17:20:10 UTC) #2
danilchap
Description was changed from ========== Do not regenerate ssrc on SetSendingStatus ssrc uniqness should be ...
3 years, 10 months ago (2017-01-30 17:23:02 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-30 17:42:32 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/14945)
3 years, 10 months ago (2017-01-30 17:42:33 UTC) #5
danilchap
3 years, 10 months ago (2017-02-09 15:17:12 UTC) #6 
Patchset #2 (id:20001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698