tracing/tracing/metrics/v8/execution_metric.html - Issue 2656493002: Register metric Histogram names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/v8/execution_metric.html

Issue 2656493002: Register metric Histogram names. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/v8/execution_metric.html

diff --git a/tracing/tracing/metrics/v8/execution_metric.html b/tracing/tracing/metrics/v8/execution_metric.html

index 4fd0983b6c0cf97f119bd63919fff466f8a116bd..b8528fc1a2249dc8cf5c8c098e2bcd8b31a9445f 100644

--- a/tracing/tracing/metrics/v8/execution_metric.html

+++ b/tracing/tracing/metrics/v8/execution_metric.html

@@ -217,7 +217,9 @@ tr.exportTo('tr.metrics.v8', function() {

computeDeoptimizeCodeMetrics(values, model);

}

- tr.metrics.MetricRegistry.register(executionMetric);

+ tr.metrics.MetricRegistry.register(executionMetric, {

+ histogramNames: new Set([]),

+ });

return {

executionMetric,