Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2655033002: Prioritize video packets when sending padding or preemptive retransmits. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 3b4238c47da00fe4c07a3654d2ecdf1a7bedd303..0e7d954c7009788ca1b9557359a561becb720df4 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -797,8 +797,13 @@ VideoSendStreamImpl::VideoSendStreamImpl(
config_->periodic_alr_bandwidth_probing);
// RTP/RTCP initialization.
- for (RtpRtcp* rtp_rtcp : rtp_rtcp_modules_) {
- packet_router_->AddRtpModule(rtp_rtcp);
+
+ // We add the highest spatial layer first to ensure it'll be prioritized
+ // when sending padding, with the hope that the packet rate will be smaller,
mflodman 2017/01/26 13:01:40 Isn't this the opposite? AddRtpModule does a push_
stefan-webrtc 2017/01/27 11:52:38 Yes, you are right. Thanks :)
+ // and that it's more important to protect than the lower layers.
+ for (auto rit = rtp_rtcp_modules_.rbegin(); rit != rtp_rtcp_modules_.rend();
+ ++rit) {
+ packet_router->AddRtpModule(*rit);
}
for (size_t i = 0; i < config_->rtp.extensions.size(); ++i) {
« webrtc/modules/pacing/packet_router.cc ('K') | « webrtc/modules/pacing/packet_router_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698