Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: webrtc/call/call.cc

Issue 2653883002: Set the start bitrate to the delay-based BWE. (Closed)
Patch Set: Add test. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/call/rampup_tests.h » ('j') | webrtc/call/rampup_tests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index 48072d0a0b71790bf2802289cef4324abdaaabe1..2cca579ae672c028c48e947f4c477fc79ed0a7b5 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -307,7 +307,7 @@ Call::Call(const Call::Config& config)
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
RTC_DCHECK(config.event_log != nullptr);
RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0);
- RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps,
+ RTC_DCHECK_GT(config.bitrate_config.start_bitrate_bps,
terelius 2017/01/24 16:05:52 Why not DCHECK_GE? That seems more natural to me.
stefan-webrtc 2017/01/24 16:29:43 It's just a bit unclear to me why you'd want to st
terelius 2017/01/25 16:41:27 Ok, I see. Is there a reason for allowing min_bitr
stefan-webrtc 2017/01/27 09:27:05 Good question. It will immediately get clamped her
config.bitrate_config.min_bitrate_bps);
if (config.bitrate_config.max_bitrate_bps != -1) {
RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps,
@@ -816,6 +816,7 @@ void Call::SetBitrateConfig(
if (bitrate_config.start_bitrate_bps > 0)
config_.bitrate_config.start_bitrate_bps = bitrate_config.start_bitrate_bps;
config_.bitrate_config.max_bitrate_bps = bitrate_config.max_bitrate_bps;
+ RTC_DCHECK_NE(bitrate_config.start_bitrate_bps, 0);
congestion_controller_->SetBweBitrates(bitrate_config.min_bitrate_bps,
bitrate_config.start_bitrate_bps,
bitrate_config.max_bitrate_bps);
@@ -912,6 +913,7 @@ void Call::OnNetworkRouteChanged(const std::string& transport_name,
<< " bps, start: " << config_.bitrate_config.start_bitrate_bps
<< " bps, max: " << config_.bitrate_config.start_bitrate_bps
<< " bps.";
+ RTC_DCHECK_GT(config_.bitrate_config.start_bitrate_bps, 0);
congestion_controller_->ResetBweAndBitrates(
config_.bitrate_config.start_bitrate_bps,
config_.bitrate_config.min_bitrate_bps,
« no previous file with comments | « no previous file | webrtc/call/rampup_tests.h » ('j') | webrtc/call/rampup_tests.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698