Add CreatePeerConnectionFactory overloads that take audio codec factory args

webrtc/pc/peerconnectionfactory.h

Index: webrtc/pc/peerconnectionfactory.h
diff --git a/webrtc/pc/peerconnectionfactory.h b/webrtc/pc/peerconnectionfactory.h
index 6e77d912679cb6813401add2f7b101c20302ec7d..36622b2b9c8d1ac2e5070808bacdaf870442bd74 100644
--- a/webrtc/pc/peerconnectionfactory.h
+++ b/webrtc/pc/peerconnectionfactory.h
@@ -102,14 +102,16 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {
   const Options& options() const { return options_; }
 
  protected:
-  PeerConnectionFactory();
+  PeerConnectionFactory(
+      rtc::scoped_refptr<webrtc::AudioEncoderFactory> audio_encoder_factory,
+      rtc::scoped_refptr<webrtc::AudioDecoderFactory> audio_decoder_factory);
   PeerConnectionFactory(
       rtc::Thread* network_thread,
       rtc::Thread* worker_thread,
       rtc::Thread* signaling_thread,
       AudioDeviceModule* default_adm,
-      const rtc::scoped_refptr<webrtc::AudioDecoderFactory>&
-          audio_decoder_factory,
+      rtc::scoped_refptr<webrtc::AudioEncoderFactory> audio_encoder_factory,
+      rtc::scoped_refptr<webrtc::AudioDecoderFactory> audio_decoder_factory,
       cricket::WebRtcVideoEncoderFactory* video_encoder_factory,
       cricket::WebRtcVideoDecoderFactory* video_decoder_factory,
       rtc::scoped_refptr<AudioMixer> audio_mixer);
@@ -126,6 +128,7 @@ class PeerConnectionFactory : public PeerConnectionFactoryInterface {
   Options options_;
   // External Audio device used for audio playback.
   rtc::scoped_refptr<AudioDeviceModule> default_adm_;
+  rtc::scoped_refptr<AudioEncoderFactory> audio_encoder_factory_;

[ossu, 2017/01/26 12:53:53]

I expected with the API change we'd just drop the AudioEncoderFactory in the
PeerConnectionFactory constructor, for now, since it has no implementation. Did
I misunderstand?

[kwiberg-webrtc, 2017/01/30 13:15:21]

No, I just chose a slightly different place to drop it than you expected.

I made a new patch set that removes this member variable, but still takes a
webrtc::AudioEncoderFactory argument in the PeerConnectionFactory constructors.

   rtc::scoped_refptr<AudioDecoderFactory> audio_decoder_factory_;
   std::unique_ptr<cricket::ChannelManager> channel_manager_;
   // External Video encoder factory. This can be NULL if the client has not