Reland of GN: Refactor modules_unittests to eliminate package boundary violations.

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../webrtc.gni")
 import("audio_coding.gni")
@@ skipping 1121 matching lines @@
       ":neteq_speed_test",
       ":rtp_analyze",
       ":rtpcat",
       ":webrtc_opus_fec_test",
     ]
     if (rtc_enable_protobuf) {
       public_deps += [ ":neteq_rtpplay" ]
     }
   }
 
+  rtc_source_set("audio_coding_modules_tests") {

[stefan-webrtc, 2017/01/26 14:39:27]

What's the difference between this and audio_coding_tests above? They are named
very similarly.

+    testonly = true
+    sources = [
+      "test/APITest.cc",
+      "test/Channel.cc",
+      "test/EncodeDecodeTest.cc",
+      "test/PCMFile.cc",
+      "test/PacketLossTest.cc",
+      "test/RTPFile.cc",
+      "test/TestAllCodecs.cc",
+      "test/TestRedFec.cc",
+      "test/TestStereo.cc",
+      "test/TestVADDTX.cc",
+      "test/Tester.cc",
+      "test/TwoWayCommunication.cc",
+      "test/iSACTest.cc",
+      "test/opus_test.cc",
+      "test/target_delay_unittest.cc",
+      "test/utility.cc",
+    ]
+    deps = [
+      ":audio_coding",
+      ":audio_format_conversion",
+      ":builtin_audio_decoder_factory",
+      ":pcm16b_c",
+      "../..:webrtc_common",
+      "../../base:rtc_base_approved",
+      "../../system_wrappers:system_wrappers",
+      "../../test:fileutils",
+      "../../test:test_support",
+    ]
+    defines = audio_coding_defines
+    if (is_win) {
+      cflags = [
+        # TODO(kjellander): bugs.webrtc.org/261: Fix this warning.
+        "/wd4373",  # virtual function override.
+      ]
+    }
+    if (!build_with_chromium && is_clang) {
+      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+    }
+  }
+
   rtc_source_set("audio_coding_perf_tests") {
     testonly = true
     sources = [
       "codecs/opus/opus_complexity_unittest.cc",
       "neteq/test/neteq_performance_unittest.cc",
     ]
     deps = [
       ":neteq_test_support",
       ":neteq_unittest_tools",
       ":webrtc_opus",
@@ skipping 911 matching lines @@
         ":neteq_unittest_proto",
       ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }