Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler_unittest.cc

Issue 2652893015: Rename adaptation api methods, extended vie_encoder unit test. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
diff --git a/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc b/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
index ada0e98ef9d9142542deb70aaffc40ac4e4cec15..f509b2ee8d69f6af02dc951f673e2496a66180cc 100644
--- a/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
+++ b/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
@@ -26,16 +26,16 @@ static const int kHighQp = 40;
static const size_t kDefaultTimeoutMs = 150;
} // namespace
-class MockScaleObserver : public ScalingObserverInterface {
+class MockScaleObserver : public AdaptationObserverInterface {
nisse-webrtc 2017/01/30 09:16:45 Could rename scale --> adapt everywhere in this cl
sprang_webrtc 2017/01/30 09:55:05 As related to the interface I think it makes sense
public:
MockScaleObserver() : event(false, false) {}
virtual ~MockScaleObserver() {}
- void ScaleUp(ScaleReason r) override {
+ void AdaptUp(AdaptReason r) override {
scaled_up++;
event.Set();
}
- void ScaleDown(ScaleReason r) override {
+ void AdaptDown(AdaptReason r) override {
scaled_down++;
event.Set();
}
@@ -48,7 +48,7 @@ class MockScaleObserver : public ScalingObserverInterface {
// Pass a lower sampling period to speed up the tests.
class QualityScalerUnderTest : public QualityScaler {
public:
- explicit QualityScalerUnderTest(ScalingObserverInterface* observer,
+ explicit QualityScalerUnderTest(AdaptationObserverInterface* observer,
VideoEncoder::QpThresholds thresholds)
: QualityScaler(observer, thresholds, 5) {}
};

Powered by Google App Engine
This is Rietveld 408576698