Refactor FakeAudioDevice to have separate methods for starting recording and playout.

webrtc/call/call_perf_tests.cc

Index: webrtc/call/call_perf_tests.cc
diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc
index 782b45c9f273ffd6fe180fa59a2b49d2d5d914ee..bb086ffb961aac7075bbdb70c74d271e28d99b6e 100644
--- a/webrtc/call/call_perf_tests.cc
+++ b/webrtc/call/call_perf_tests.cc
@@ -146,11 +146,7 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,
   metrics::Reset();
   VoiceEngine* voice_engine = VoiceEngine::Create();
   VoEBase* voe_base = VoEBase::GetInterface(voice_engine);
-  const std::string audio_filename =
-      test::ResourcePath("voice_engine/audio_long16", "pcm");
-  ASSERT_STRNE("", audio_filename.c_str());
-  FakeAudioDevice fake_audio_device(Clock::GetRealTimeClock(), audio_filename,
-                                    audio_rtp_speed);
+  FakeAudioDevice fake_audio_device(Clock::GetRealTimeClock(), audio_rtp_speed);
   EXPECT_EQ(0, voe_base->Init(&fake_audio_device, nullptr, decoder_factory_));
   VoEBase::ChannelConfig config;
   config.enable_voice_pacing = true;
@@ -264,7 +260,8 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,
 
   Start();
 
-  fake_audio_device.Start();
+  fake_audio_device.StartRecordingSine(1000, 256);
+  fake_audio_device.StartPlayout();
   audio_receive_stream->Start();
   EXPECT_EQ(0, voe_base->StartSend(send_channel_id));
 
@@ -273,7 +270,8 @@ void CallPerfTest::TestAudioVideoSync(FecMode fec,
 
   EXPECT_EQ(0, voe_base->StopSend(send_channel_id));
   EXPECT_EQ(0, voe_base->StopPlayout(recv_channel_id));
-  fake_audio_device.Stop();
+  fake_audio_device.StopPlayout();

[the sun, 2017/01/24 08:58:12]

nit: stop/start in same order - these operations shouldn't have any shared state
that needs undoing in a specific order.

[perkj_webrtc, 2017/01/24 09:57:02]

Done.

+  fake_audio_device.StopRecording();
 
   Stop();
   video_send_transport.StopSending();