Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/audio_device/include/fake_audio_device.h

Issue 2652803002: Refactor FakeAudioDevice to have separate methods for starting recording and playout. (Closed)
Patch Set: Moved initialization to ctor. Made StartRecording and StartPlayout to private. Fixed call_test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/call/call_perf_tests.cc ('K') | « webrtc/call/call_perf_tests.cc ('k') | webrtc/test/BUILD.gn » ('j') | webrtc/test/fake_audio_device.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_device/include/fake_audio_device.h
diff --git a/webrtc/modules/audio_device/include/fake_audio_device.h b/webrtc/modules/audio_device/include/fake_audio_device.h
index 98fd2f46f63f991d76995dd3dd61302ebd869ed1..a28ad8646436eaaec4f2a7bb016c927e5cc3d7ab 100644
--- a/webrtc/modules/audio_device/include/fake_audio_device.h
+++ b/webrtc/modules/audio_device/include/fake_audio_device.h
@@ -21,6 +21,8 @@ class FakeAudioDeviceModule : public AudioDeviceModule {
virtual ~FakeAudioDeviceModule() {}
virtual int32_t AddRef() const { return 0; }
virtual int32_t Release() const { return 0; }
+
+ private:
virtual int32_t RegisterEventObserver(AudioDeviceObserver* eventCallback) {
return 0;
}
@@ -121,7 +123,10 @@ class FakeAudioDeviceModule : public AudioDeviceModule {
virtual int32_t PlayoutBuffer(BufferType* type, uint16_t* sizeMS) const {
return 0;
}
- virtual int32_t PlayoutDelay(uint16_t* delayMS) const { return 0; }
+ virtual int32_t PlayoutDelay(uint16_t* delayMS) const {
+ *delayMS = 0;
+ return 0;
+ }
virtual int32_t RecordingDelay(uint16_t* delayMS) const { return 0; }
virtual int32_t CPULoad(uint16_t* load) const { return 0; }
virtual int32_t StartRawOutputFileRecording(
« webrtc/call/call_perf_tests.cc ('K') | « webrtc/call/call_perf_tests.cc ('k') | webrtc/test/BUILD.gn » ('j') | webrtc/test/fake_audio_device.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698