Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: webrtc/sdk/android/api/org/webrtc/RtpParameters.java

Issue 2651883010: Adding C++ versions of currently spec'd "RtpParameters" structs. (Closed)
Patch Set: Update unit tests (due to switch from special-case values to rtc::Optional) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/rtpsenderreceiver_unittest.cc ('k') | webrtc/sdk/android/src/jni/peerconnection_jni.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/api/org/webrtc/RtpParameters.java
diff --git a/webrtc/sdk/android/api/org/webrtc/RtpParameters.java b/webrtc/sdk/android/api/org/webrtc/RtpParameters.java
index a50cf550f56e2f1b74f669450d9664d841b093cf..fde2b35502dec58a92adbcf6cde2a429b55a6dbe 100644
--- a/webrtc/sdk/android/api/org/webrtc/RtpParameters.java
+++ b/webrtc/sdk/android/api/org/webrtc/RtpParameters.java
@@ -15,23 +15,43 @@ import java.util.LinkedList;
/**
* The parameters for an {@code RtpSender}, as defined in
* http://w3c.github.io/webrtc-pc/#rtcrtpsender-interface.
+ *
+ * Note: These structures use nullable Integer/etc. types because in the
+ * future, they may be used to construct ORTC RtpSender/RtpReceivers, in
+ * which case "null" will be used to represent "choose the implementation
+ * default value".
*/
public class RtpParameters {
public static class Encoding {
+ // Set to true to cause this encoding to be sent, and false for it not to
+ // be sent.
public boolean active = true;
- // A null value means "no maximum bitrate".
+ // If non-null, this represents the Transport Independent Application
+ // Specific maximum bandwidth defined in RFC3890. If null, there is no
+ // maximum bitrate.
public Integer maxBitrateBps;
+ // SSRC to be used by this encoding.
+ // Can't be changed between getParameters/setParameters.
public Long ssrc;
}
public static class Codec {
- int payloadType;
- String mimeType;
- int clockRate;
- int channels = 1;
+ // Payload type used to identify this codec in RTP packets.
+ public int payloadType;
+ // Name used to identify the codec. Equivalent to MIME subtype.
+ public String name;
+ // The media type of this codec. Equivalent to MIME top-level type.
+ MediaStreamTrack.MediaType kind;
+ // Clock rate in Hertz.
+ public Integer clockRate;
+ // The number of audio channels used. Set to null for video codecs.
+ public Integer numChannels;
}
public final LinkedList<Encoding> encodings;
+ // Codec parameters can't currently be changed between getParameters and
+ // setParameters. Though in the future it will be possible to reorder them or
+ // remove them.
public final LinkedList<Codec> codecs;
public RtpParameters() {
« no previous file with comments | « webrtc/pc/rtpsenderreceiver_unittest.cc ('k') | webrtc/sdk/android/src/jni/peerconnection_jni.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698