webrtc/media/engine/webrtcvoiceengine_unittest.cc - Issue 2651883010: Adding C++ versions of currently spec'd "RtpParameters" structs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine_unittest.cc

Issue 2651883010: Adding C++ versions of currently spec'd "RtpParameters" structs. (Closed)

Patch Set: Update unit tests (due to switch from special-case values to rtc::Optional) Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/engine/webrtcvoiceengine_unittest.cc

diff --git a/webrtc/media/engine/webrtcvoiceengine_unittest.cc b/webrtc/media/engine/webrtcvoiceengine_unittest.cc

index 526f7cc3abd59b52df59d75a6d569048baa5597a..a7ea8c2c9257b5720ed72c1ea68530b76804e0dd 100644

--- a/webrtc/media/engine/webrtcvoiceengine_unittest.cc

+++ b/webrtc/media/engine/webrtcvoiceengine_unittest.cc

@@ -289,7 +289,7 @@ class WebRtcVoiceEngineTestFake : public testing::Test {

webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrc);

EXPECT_EQ(1UL, parameters.encodings.size());

- parameters.encodings[0].max_bitrate_bps = bitrate;

+ parameters.encodings[0].max_bitrate_bps = rtc::Optional<int>(bitrate);

return channel_->SetRtpSendParameters(ssrc, parameters);

}

« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/pc/channel_unittest.cc » ('j') | no next file with comments »