Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: webrtc/pc/rtpsenderreceiver_unittest.cc

Issue 2651883010: Adding C++ versions of currently spec'd "RtpParameters" structs. (Closed)
Patch Set: Fixing typo in test. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 547
548 DestroyAudioRtpSender(); 548 DestroyAudioRtpSender();
549 } 549 }
550 550
551 TEST_F(RtpSenderReceiverTest, SetAudioMaxSendBitrate) { 551 TEST_F(RtpSenderReceiverTest, SetAudioMaxSendBitrate) {
552 CreateAudioRtpSender(); 552 CreateAudioRtpSender();
553 553
554 EXPECT_EQ(-1, voice_media_channel_->max_bps()); 554 EXPECT_EQ(-1, voice_media_channel_->max_bps());
555 webrtc::RtpParameters params = audio_rtp_sender_->GetParameters(); 555 webrtc::RtpParameters params = audio_rtp_sender_->GetParameters();
556 EXPECT_EQ(1, params.encodings.size()); 556 EXPECT_EQ(1, params.encodings.size());
557 EXPECT_EQ(-1, params.encodings[0].max_bitrate_bps); 557 EXPECT_FALSE(params.encodings[0].max_bitrate_bps);
558 params.encodings[0].max_bitrate_bps = 1000; 558 params.encodings[0].max_bitrate_bps = rtc::Optional<int>(1000);
559 EXPECT_TRUE(audio_rtp_sender_->SetParameters(params)); 559 EXPECT_TRUE(audio_rtp_sender_->SetParameters(params));
560 560
561 // Read back the parameters and verify they have been changed. 561 // Read back the parameters and verify they have been changed.
562 params = audio_rtp_sender_->GetParameters(); 562 params = audio_rtp_sender_->GetParameters();
563 EXPECT_EQ(1, params.encodings.size()); 563 EXPECT_EQ(1, params.encodings.size());
564 EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps); 564 EXPECT_EQ(rtc::Optional<int>(1000), params.encodings[0].max_bitrate_bps);
565 565
566 // Verify that the audio channel received the new parameters. 566 // Verify that the audio channel received the new parameters.
567 params = voice_media_channel_->GetRtpSendParameters(kAudioSsrc); 567 params = voice_media_channel_->GetRtpSendParameters(kAudioSsrc);
568 EXPECT_EQ(1, params.encodings.size()); 568 EXPECT_EQ(1, params.encodings.size());
569 EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps); 569 EXPECT_EQ(rtc::Optional<int>(1000), params.encodings[0].max_bitrate_bps);
570 570
571 // Verify that the global bitrate limit has not been changed. 571 // Verify that the global bitrate limit has not been changed.
572 EXPECT_EQ(-1, voice_media_channel_->max_bps()); 572 EXPECT_EQ(-1, voice_media_channel_->max_bps());
573 573
574 DestroyAudioRtpSender(); 574 DestroyAudioRtpSender();
575 } 575 }
576 576
577 TEST_F(RtpSenderReceiverTest, VideoSenderCanSetParameters) { 577 TEST_F(RtpSenderReceiverTest, VideoSenderCanSetParameters) {
578 CreateVideoRtpSender(); 578 CreateVideoRtpSender();
579 579
580 RtpParameters params = video_rtp_sender_->GetParameters(); 580 RtpParameters params = video_rtp_sender_->GetParameters();
581 EXPECT_EQ(1u, params.encodings.size()); 581 EXPECT_EQ(1u, params.encodings.size());
582 EXPECT_TRUE(video_rtp_sender_->SetParameters(params)); 582 EXPECT_TRUE(video_rtp_sender_->SetParameters(params));
583 583
584 DestroyVideoRtpSender(); 584 DestroyVideoRtpSender();
585 } 585 }
586 586
587 TEST_F(RtpSenderReceiverTest, SetVideoMaxSendBitrate) { 587 TEST_F(RtpSenderReceiverTest, SetVideoMaxSendBitrate) {
588 CreateVideoRtpSender(); 588 CreateVideoRtpSender();
589 589
590 EXPECT_EQ(-1, video_media_channel_->max_bps()); 590 EXPECT_EQ(-1, video_media_channel_->max_bps());
591 webrtc::RtpParameters params = video_rtp_sender_->GetParameters(); 591 webrtc::RtpParameters params = video_rtp_sender_->GetParameters();
592 EXPECT_EQ(1, params.encodings.size()); 592 EXPECT_EQ(1, params.encodings.size());
593 EXPECT_EQ(-1, params.encodings[0].max_bitrate_bps); 593 EXPECT_FALSE(params.encodings[0].max_bitrate_bps);
594 params.encodings[0].max_bitrate_bps = 1000; 594 params.encodings[0].max_bitrate_bps = rtc::Optional<int>(1000);
595 EXPECT_TRUE(video_rtp_sender_->SetParameters(params)); 595 EXPECT_TRUE(video_rtp_sender_->SetParameters(params));
596 596
597 // Read back the parameters and verify they have been changed. 597 // Read back the parameters and verify they have been changed.
598 params = video_rtp_sender_->GetParameters(); 598 params = video_rtp_sender_->GetParameters();
599 EXPECT_EQ(1, params.encodings.size()); 599 EXPECT_EQ(1, params.encodings.size());
600 EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps); 600 EXPECT_EQ(rtc::Optional<int>(1000), params.encodings[0].max_bitrate_bps);
601 601
602 // Verify that the video channel received the new parameters. 602 // Verify that the video channel received the new parameters.
603 params = video_media_channel_->GetRtpSendParameters(kVideoSsrc); 603 params = video_media_channel_->GetRtpSendParameters(kVideoSsrc);
604 EXPECT_EQ(1, params.encodings.size()); 604 EXPECT_EQ(1, params.encodings.size());
605 EXPECT_EQ(1000, params.encodings[0].max_bitrate_bps); 605 EXPECT_EQ(rtc::Optional<int>(1000), params.encodings[0].max_bitrate_bps);
606 606
607 // Verify that the global bitrate limit has not been changed. 607 // Verify that the global bitrate limit has not been changed.
608 EXPECT_EQ(-1, video_media_channel_->max_bps()); 608 EXPECT_EQ(-1, video_media_channel_->max_bps());
609 609
610 DestroyVideoRtpSender(); 610 DestroyVideoRtpSender();
611 } 611 }
612 612
613 TEST_F(RtpSenderReceiverTest, AudioReceiverCanSetParameters) { 613 TEST_F(RtpSenderReceiverTest, AudioReceiverCanSetParameters) {
614 CreateAudioRtpReceiver(); 614 CreateAudioRtpReceiver();
615 615
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 // And removing the hint should go back to false (to verify that false was 715 // And removing the hint should go back to false (to verify that false was
716 // default correctly). 716 // default correctly).
717 video_track_->set_content_hint(VideoTrackInterface::ContentHint::kNone); 717 video_track_->set_content_hint(VideoTrackInterface::ContentHint::kNone);
718 EXPECT_EQ(rtc::Optional<bool>(false), 718 EXPECT_EQ(rtc::Optional<bool>(false),
719 video_media_channel_->options().is_screencast); 719 video_media_channel_->options().is_screencast);
720 720
721 DestroyVideoRtpSender(); 721 DestroyVideoRtpSender();
722 } 722 }
723 723
724 } // namespace webrtc 724 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698