Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/metal/RTCMTLVideoView.m

Issue 2651743007: Add metal view, shaders and renderer. (Closed)
Patch Set: Add metal renderer protocol and rename implementation classes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
kthelgason 2017/02/03 09:17:23 2017
daniela-webrtc 2017/02/07 10:51:08 Done.
daniela-webrtc 2017/02/07 10:51:08 Done.
3 *
4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
9 */
10
11 #import "WebRTC/RTCMTLVideoView.h"
kthelgason 2017/02/03 09:17:23 blank line between this files' header and system h
daniela-webrtc 2017/02/07 10:51:08 Done.
daniela-webrtc 2017/02/07 10:51:09 Done.
12 #import <Metal/Metal.h>
kthelgason 2017/02/03 09:17:23 Blank line between system headers and other projec
daniela-webrtc 2017/02/07 10:51:08 Done.
daniela-webrtc 2017/02/07 10:51:09 Done.
13 #import "RTCNV12Renderer.h"
kthelgason 2017/02/03 09:17:23 This import should be prefixed with WebRTC/
kthelgason 2017/02/03 09:17:23 This import should be prefixed with WebRTC/
daniela-webrtc 2017/02/07 10:51:08 The WebRTC/ prefix works only for public framework
14
15 @interface RTCMTLVideoView ()
16 @property(nonatomic) id<RTCMTLRenderer> renderer;
17 @end
18
19 @implementation RTCMTLVideoView {
20 id<RTCMTLRenderer> _renderer;
21 }
22
23 @synthesize renderer = _renderer;
24
25 - (instancetype)initWithFrame:(CGRect)frameRect device:(nullable id<MTLDevice>)d evice {
26 self = [super initWithFrame:frameRect device:device];
27 if (self) {
28 _renderer = [[RTCNV12Renderer alloc] initWithView:self];
29 }
30 return self;
31 }
32
33 - (BOOL)setupRenderer {
34 return [_renderer setup];
35 }
36
37 @end
kthelgason 2017/02/03 09:17:23 I think this file should have a .mm extension, but
daniela-webrtc 2017/02/07 10:51:09 Since this class is pure objective-c (doesn't have
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698