webrtc/sdk/objc/Framework/Classes/metal/RTCNV12Renderer.h - Issue 2651743007: Add metal view, shaders and renderer.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/metal/RTCNV12Renderer.h

Issue 2651743007: Add metal view, shaders and renderer. (Closed)

Patch Set: Link metal libraries only for arm64cpu Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/metal/RTCMTLVideoView.m ('k') | webrtc/sdk/objc/Framework/Classes/metal/RTCNV12Renderer.mm » ('j') | webrtc/sdk/objc/Framework/Classes/metal/RTCNV12Renderer.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /*

	2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.

	3 *

	4 * Use of this source code is governed by a BSD-style license

	5 * that can be found in the LICENSE file in the root of the source

	6 * tree. An additional intellectual property rights grant can be found

	7 * in the file PATENTS. All contributing project authors may

	8 * be found in the AUTHORS file in the root of the source tree.

	9 */

	10

	11 #import <Foundation/Foundation.h>
	tkchin_webrtc 2017/02/10 23:32:10 nit: newline after system imports nit: newline after system imports daniela-webrtc 2017/02/13 12:32:06 Done. Show quoted text On 2017/02/10 23:32:10, tkchin_webrtc wrote: > nit: newline after system imports Done.
	12 #import "WebRTC/RTCMTLRenderer.h"

	13

	14 /**

	15 * Implementation of RTCMTLRenderer protocol for rendering native nv12 video fra mes.
	tkchin_webrtc 2017/02/10 23:32:09 nit: place after / Imple.. nit: place after / Imple.. daniela-webrtc 2017/02/13 12:32:06 Done. Show quoted text On 2017/02/10 23:32:09, tkchin_webrtc wrote: > nit: place after > / Imple.. Done.
	16 */

	17 @interface RTCNV12Renderer : NSObject<RTCMTLRenderer>
	tkchin_webrtc 2017/02/10 23:32:10 Should this be RTCNV12MetalRenderer? Do we have p Should this be RTCNV12MetalRenderer? Do we have plans to compare Metal vs OpenGL perf? tkchin_webrtc 2017/02/10 23:32:10 nit: NSObject < nit: NSObject < daniela-webrtc 2017/02/13 12:32:06 According to the guidelines (and the Clang formatt Show quoted text On 2017/02/10 23:32:10, tkchin_webrtc wrote: > nit: NSObject < According to the guidelines (and the Clang formatter that I use locally) there should be no space. https://google.github.io/styleguide/objcguide.xml?showone=Protocols#Protocols tkchin_webrtc 2017/02/14 00:23:54 See internal style guide (rev. 3.85). There isn't Show quoted text On 2017/02/13 12:32:06, denicija-webrtc wrote: > On 2017/02/10 23:32:10, tkchin_webrtc wrote: > > nit: NSObject < > > According to the guidelines (and the Clang formatter that I use locally) there > should be no space. > https://google.github.io/styleguide/objcguide.xml?showone=Protocols#Protocols See internal style guide (rev. 3.85). There isn't official guidance here, so we should stay consistent with our own rep and use a space. Personally I recommend following style of core Google components.
	18 @end

OLD	NEW