third_party/WebKit/Source/core/layout/LayoutListBox.cpp - Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListBox.cpp

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)

Patch Set: Fixed nits. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutListBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp b/third_party/WebKit/Source/core/layout/LayoutListBox.cpp

index d3a45d6cc1e8933a7d7da4ed25e6be879216f31d..fb7cbd9af25b3441da80e6a4ac3eda1df37f11c9 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListBox.cpp

@@ -133,7 +133,7 @@ void LayoutListBox::ScrollToRect(const LayoutRect& rect) {

DCHECK(Layer()->GetScrollableArea());

Layer()->GetScrollableArea()->ScrollIntoView(

rect, ScrollAlignment::kAlignToEdgeIfNeeded,

- ScrollAlignment::kAlignToEdgeIfNeeded);

+ ScrollAlignment::kAlignToEdgeIfNeeded, false);

}