Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2650343008: Implement Element.scrollIntoView for scroll-behavior: smooth. (Closed)
Patch Set: Add a short comment. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 #include "platform/RuntimeEnabledFeatures.h" 44 #include "platform/RuntimeEnabledFeatures.h"
45 #include "platform/animation/CompositorAnimationHost.h" 45 #include "platform/animation/CompositorAnimationHost.h"
46 #include "platform/animation/CompositorAnimationTimeline.h" 46 #include "platform/animation/CompositorAnimationTimeline.h"
47 #include "platform/geometry/IntRect.h" 47 #include "platform/geometry/IntRect.h"
48 #include "platform/geometry/LayoutRect.h" 48 #include "platform/geometry/LayoutRect.h"
49 #include "platform/graphics/Color.h" 49 #include "platform/graphics/Color.h"
50 #include "platform/graphics/CompositorElementId.h" 50 #include "platform/graphics/CompositorElementId.h"
51 #include "platform/graphics/GraphicsLayerClient.h" 51 #include "platform/graphics/GraphicsLayerClient.h"
52 #include "platform/scroll/ScrollTypes.h" 52 #include "platform/scroll/ScrollTypes.h"
53 #include "platform/scroll/Scrollbar.h" 53 #include "platform/scroll/Scrollbar.h"
54 #include "platform/scroll/SmoothScrollSequencer.h"
54 #include "platform/wtf/Allocator.h" 55 #include "platform/wtf/Allocator.h"
55 #include "platform/wtf/AutoReset.h" 56 #include "platform/wtf/AutoReset.h"
56 #include "platform/wtf/Forward.h" 57 #include "platform/wtf/Forward.h"
57 #include "platform/wtf/HashSet.h" 58 #include "platform/wtf/HashSet.h"
58 #include "platform/wtf/ListHashSet.h" 59 #include "platform/wtf/ListHashSet.h"
59 #include "platform/wtf/text/WTFString.h" 60 #include "platform/wtf/text/WTFString.h"
60 #include "public/platform/ShapeProperties.h" 61 #include "public/platform/ShapeProperties.h"
61 #include "public/platform/WebDisplayMode.h" 62 #include "public/platform/WebDisplayMode.h"
62 #include "public/platform/WebRect.h" 63 #include "public/platform/WebRect.h"
63 64
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 CompositorAnimationTimeline* GetCompositorAnimationTimeline() const override; 468 CompositorAnimationTimeline* GetCompositorAnimationTimeline() const override;
468 LayoutBox* GetLayoutBox() const override; 469 LayoutBox* GetLayoutBox() const override;
469 FloatQuad LocalToVisibleContentQuad(const FloatQuad&, 470 FloatQuad LocalToVisibleContentQuad(const FloatQuad&,
470 const LayoutObject*, 471 const LayoutObject*,
471 unsigned = 0) const final; 472 unsigned = 0) const final;
472 RefPtr<WebTaskRunner> GetTimerTaskRunner() const final; 473 RefPtr<WebTaskRunner> GetTimerTaskRunner() const final;
473 474
474 LayoutRect ScrollIntoView(const LayoutRect& rect_in_content, 475 LayoutRect ScrollIntoView(const LayoutRect& rect_in_content,
475 const ScrollAlignment& align_x, 476 const ScrollAlignment& align_x,
476 const ScrollAlignment& align_y, 477 const ScrollAlignment& align_y,
478 bool is_smooth,
477 ScrollType = kProgrammaticScroll) override; 479 ScrollType = kProgrammaticScroll) override;
478 480
479 // The window that hosts the FrameView. The FrameView will communicate scrolls 481 // The window that hosts the FrameView. The FrameView will communicate scrolls
480 // and repaints to the host window in the window's coordinate space. 482 // and repaints to the host window in the window's coordinate space.
481 PlatformChromeClient* GetChromeClient() const; 483 PlatformChromeClient* GetChromeClient() const;
482 484
485 SmoothScrollSequencer* GetSmoothScrollSequencer() const override;
486
483 // Functions for child manipulation and inspection. 487 // Functions for child manipulation and inspection.
484 bool IsSelfVisible() const { 488 bool IsSelfVisible() const {
485 return self_visible_; 489 return self_visible_;
486 } // Whether or not we have been explicitly marked as visible or not. 490 } // Whether or not we have been explicitly marked as visible or not.
487 bool IsParentVisible() const { 491 bool IsParentVisible() const {
488 return parent_visible_; 492 return parent_visible_;
489 } // Whether or not our parent is visible. 493 } // Whether or not our parent is visible.
490 bool IsVisible() const { 494 bool IsVisible() const {
491 return self_visible_ && parent_visible_; 495 return self_visible_ && parent_visible_;
492 } // Whether or not we are actually visible. 496 } // Whether or not we are actually visible.
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
1279 frame_or_plugin.IsFrameView()); 1283 frame_or_plugin.IsFrameView());
1280 DEFINE_TYPE_CASTS(FrameView, 1284 DEFINE_TYPE_CASTS(FrameView,
1281 ScrollableArea, 1285 ScrollableArea,
1282 scrollableArea, 1286 scrollableArea,
1283 scrollableArea->IsFrameView(), 1287 scrollableArea->IsFrameView(),
1284 scrollableArea.IsFrameView()); 1288 scrollableArea.IsFrameView());
1285 1289
1286 } // namespace blink 1290 } // namespace blink
1287 1291
1288 #endif // FrameView_h 1292 #endif // FrameView_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.idl ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698