Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: webrtc/video_decoder.h

Issue 2649133005: Add QP sum stats for received streams. (Closed)
Patch Set: Changes according to hbos's comments. #1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video_decoder.h
diff --git a/webrtc/video_decoder.h b/webrtc/video_decoder.h
index b8d2c96b1be8da1cb27138f0550302ebe7b378c1..2ab8c3b2105be2034b5f9dc8d6f3623d04bca578 100644
--- a/webrtc/video_decoder.h
+++ b/webrtc/video_decoder.h
@@ -35,11 +35,15 @@ class DecodedImageCallback {
// decode time excluding waiting time for any previous pending frame to
// return. This is necessary for breaking positive feedback in the delay
// estimation when the decoder has a single output buffer.
- // TODO(perkj): Remove default implementation when chromium has been updated.
virtual int32_t Decoded(VideoFrame& decodedImage, int64_t decode_time_ms) {
// The default implementation ignores custom decode time value.
return Decoded(decodedImage);
}
+ // TODO(sakal): Remove other implementations when upstream projects have been
+ // updated.
+ virtual int32_t Decoded(VideoFrame& decodedImage,
+ int64_t decode_time_ms,
+ int qp) = 0;
virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId) {
return -1;

Powered by Google App Engine
This is Rietveld 408576698