Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: webrtc/video/video_receive_stream.cc

Issue 2649133005: Add QP sum stats for received streams. (Closed)
Patch Set: Add DecodedWithQp to interface. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/video_receive_stream.cc
diff --git a/webrtc/video/video_receive_stream.cc b/webrtc/video/video_receive_stream.cc
index 183f72b537fcf9e6f75afb6bfebe44eaf648275a..21bb42872f3a9ef3c6ede8006e611b314cec5775 100644
--- a/webrtc/video/video_receive_stream.cc
+++ b/webrtc/video/video_receive_stream.cc
@@ -381,10 +381,6 @@ VideoReceiveStream::Stats VideoReceiveStream::GetStats() const {
// TODO(tommi): This method grabs a lock 6 times.
void VideoReceiveStream::OnFrame(const VideoFrame& video_frame) {
- // TODO(tommi): OnDecodedFrame grabs a lock, incidentally the same lock
- // that OnSyncOffsetUpdated() and OnRenderedFrame() below grab.
- stats_proxy_.OnDecodedFrame();
-
hbos 2017/01/25 11:31:13 Why is this no longer called?
sakal 2017/01/25 12:39:34 It is called from VideoStreamDecoder::FrameToRende
int64_t sync_offset_ms;
double estimated_freq_khz;
// TODO(tommi): GetStreamSyncOffsetInMs grabs three locks. One inside the

Powered by Google App Engine
This is Rietveld 408576698