Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: webrtc/modules/video_coding/test/test_util.h

Issue 2649133005: Add QP sum stats for received streams. (Closed)
Patch Set: Add DecodedWithQp to interface. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/test/test_util.h
diff --git a/webrtc/modules/video_coding/test/test_util.h b/webrtc/modules/video_coding/test/test_util.h
index 45b88b9b50aa3b0260e513d0004052e5d56f62fc..9627045e12f7f8623c768f679a22450060ce9e70 100644
--- a/webrtc/modules/video_coding/test/test_util.h
+++ b/webrtc/modules/video_coding/test/test_util.h
@@ -57,7 +57,8 @@ class FileOutputFrameReceiver : public webrtc::VCMReceiveCallback {
virtual ~FileOutputFrameReceiver();
// VCMReceiveCallback
- virtual int32_t FrameToRender(webrtc::VideoFrame& video_frame); // NOLINT
+ virtual int32_t FrameToRender(webrtc::VideoFrame& video_frame,
+ int qp); // NOLINT
hbos 2017/01/25 11:31:12 Can you change virtual to override? If so do it ev
sakal 2017/01/25 12:39:34 Done for this method. I don't want to touch other
hbos 2017/01/26 15:04:45 There might be waterfall bots that complain if a f
sakal 2017/01/26 15:46:52 I changed all methods to override and removed a fe
private:
std::string out_filename_;

Powered by Google App Engine
This is Rietveld 408576698