Chromium Code Reviews| Index: webrtc/video_decoder.h |
| diff --git a/webrtc/video_decoder.h b/webrtc/video_decoder.h |
| index b8d2c96b1be8da1cb27138f0550302ebe7b378c1..3fcf747a46e6345871692ea5c43e637fca4db4e0 100644 |
| --- a/webrtc/video_decoder.h |
| +++ b/webrtc/video_decoder.h |
| @@ -35,11 +35,18 @@ class DecodedImageCallback { |
| // decode time excluding waiting time for any previous pending frame to |
| // return. This is necessary for breaking positive feedback in the delay |
| // estimation when the decoder has a single output buffer. |
| - // TODO(perkj): Remove default implementation when chromium has been updated. |
| virtual int32_t Decoded(VideoFrame& decodedImage, int64_t decode_time_ms) { |
| // The default implementation ignores custom decode time value. |
| return Decoded(decodedImage); |
| } |
| + // TODO(sakal): Remove other implementations when upstream projects have been |
| + // updated. |
| + virtual int32_t Decoded(VideoFrame& decodedImage, |
|
stefan-webrtc
2017/02/07 09:56:51
Would it be a good idea to update the return type
sakal
2017/02/07 12:28:18
I removed the return value completely since we alw
|
| + rtc::Optional<int32_t> decode_time_ms, |
| + rtc::Optional<uint8_t> qp) { |
| + return Decoded(decodedImage, |
| + decode_time_ms ? static_cast<int32_t>(*decode_time_ms) : -1); |
| + } |
| virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId) { |
| return -1; |