webrtc/modules/video_coding/generic_decoder.h - Issue 2649133005: Add QP sum stats for received streams.

Side by Side Diff: webrtc/modules/video_coding/generic_decoder.h

Issue 2649133005: Add QP sum stats for received streams. (Closed)

Patch Set: Add DecodedWithQp to interface. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc ('k') | webrtc/modules/video_coding/generic_decoder.cc » ('j') | webrtc/modules/video_coding/include/video_coding_defines.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.	2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license	4 * Use of this source code is governed by a BSD-style license

5 * that can be found in the LICENSE file in the root of the source	5 * that can be found in the LICENSE file in the root of the source

6 * tree. An additional intellectual property rights grant can be found	6 * tree. An additional intellectual property rights grant can be found

7 * in the file PATENTS. All contributing project authors may	7 * in the file PATENTS. All contributing project authors may

8 * be found in the AUTHORS file in the root of the source tree.	8 * be found in the AUTHORS file in the root of the source tree.

9 */	9 */

10	10

(...skipping 22 matching lines...) Expand all Loading...
33 class VCMDecodedFrameCallback : public DecodedImageCallback {	33 class VCMDecodedFrameCallback : public DecodedImageCallback {

34 public:	34 public:

35 VCMDecodedFrameCallback(VCMTiming* timing, Clock* clock);	35 VCMDecodedFrameCallback(VCMTiming* timing, Clock* clock);

36 virtual ~VCMDecodedFrameCallback();	36 virtual ~VCMDecodedFrameCallback();

37 void SetUserReceiveCallback(VCMReceiveCallback* receiveCallback);	37 void SetUserReceiveCallback(VCMReceiveCallback* receiveCallback);

38 VCMReceiveCallback* UserReceiveCallback();	38 VCMReceiveCallback* UserReceiveCallback();

39	39

40 virtual int32_t Decoded(VideoFrame& decodedImage); // NOLINT	40 virtual int32_t Decoded(VideoFrame& decodedImage); // NOLINT

41 virtual int32_t Decoded(VideoFrame& decodedImage, // NOLINT	41 virtual int32_t Decoded(VideoFrame& decodedImage, // NOLINT

42 int64_t decode_time_ms);	42 int64_t decode_time_ms);

	43 virtual int32_t DecodedWithQp(VideoFrame& decodedImage, // NOLINT

	44 int qp);

	45 virtual int32_t DecodedWithQp(VideoFrame& decodedImage, // NOLINT

	46 int64_t decode_time_ms,

	47 int qp);
	hbos 2017/01/25 11:31:12 nit: Can all uses of virtual be changed to overrid nit: Can all uses of virtual be changed to override? sakal 2017/01/25 12:39:34 Done. Show quoted text On 2017/01/25 11:31:12, hbos wrote: > nit: Can all uses of virtual be changed to override? Done.
43 virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId);	48 virtual int32_t ReceivedDecodedReferenceFrame(const uint64_t pictureId);

44 virtual int32_t ReceivedDecodedFrame(const uint64_t pictureId);	49 virtual int32_t ReceivedDecodedFrame(const uint64_t pictureId);

45	50

46 uint64_t LastReceivedPictureID() const;	51 uint64_t LastReceivedPictureID() const;

47 void OnDecoderImplementationName(const char* implementation_name);	52 void OnDecoderImplementationName(const char* implementation_name);

48	53

49 void Map(uint32_t timestamp, VCMFrameInformation* frameInfo);	54 void Map(uint32_t timestamp, VCMFrameInformation* frameInfo);

50 int32_t Pop(uint32_t timestamp);	55 int32_t Pop(uint32_t timestamp);

51	56

52 private:	57 private:

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97 uint32_t _nextFrameInfoIdx;	102 uint32_t _nextFrameInfoIdx;

98 VideoDecoder* const _decoder;	103 VideoDecoder* const _decoder;

99 VideoCodecType _codecType;	104 VideoCodecType _codecType;

100 bool _isExternal;	105 bool _isExternal;

101 bool _keyFrameDecoded;	106 bool _keyFrameDecoded;

102 };	107 };

103	108

104 } // namespace webrtc	109 } // namespace webrtc

105	110

106 #endif // WEBRTC_MODULES_VIDEO_CODING_GENERIC_DECODER_H_	111 #endif // WEBRTC_MODULES_VIDEO_CODING_GENERIC_DECODER_H_

OLD	NEW