Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: webrtc/p2p/base/faketransportcontroller.h

Issue 2648093002: Fixing memory leak in FakeTransportController. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/faketransportcontroller.h
diff --git a/webrtc/p2p/base/faketransportcontroller.h b/webrtc/p2p/base/faketransportcontroller.h
index d97b4b618859dbd6ffe867df51ec37ed3e7c5aea..76ed370656da1e7a1c29d6c2049762b9b9a4ea20 100644
--- a/webrtc/p2p/base/faketransportcontroller.h
+++ b/webrtc/p2p/base/faketransportcontroller.h
@@ -613,24 +613,28 @@ class FakeTransportController : public TransportController {
// exchange of ICE candidates.
void Connect(FakeTransportController* dest) {
for (const std::string& transport_name : transport_names_for_testing()) {
+ std::unique_ptr<rtc::SSLFingerprint> local_fingerprint;
+ std::unique_ptr<rtc::SSLFingerprint> remote_fingerprint;
+ if (certificate_for_testing()) {
+ local_fingerprint.reset(rtc::SSLFingerprint::CreateFromCertificate(
+ certificate_for_testing()));
+ }
+ if (dest->certificate_for_testing()) {
+ remote_fingerprint.reset(rtc::SSLFingerprint::CreateFromCertificate(
+ dest->certificate_for_testing()));
+ }
TransportDescription local_desc(
std::vector<std::string>(),
rtc::CreateRandomString(cricket::ICE_UFRAG_LENGTH),
rtc::CreateRandomString(cricket::ICE_PWD_LENGTH),
cricket::ICEMODE_FULL, cricket::CONNECTIONROLE_NONE,
- certificate_for_testing()
- ? rtc::SSLFingerprint::CreateFromCertificate(
- certificate_for_testing())
- : nullptr);
+ local_fingerprint.get());
TransportDescription remote_desc(
std::vector<std::string>(),
rtc::CreateRandomString(cricket::ICE_UFRAG_LENGTH),
rtc::CreateRandomString(cricket::ICE_PWD_LENGTH),
cricket::ICEMODE_FULL, cricket::CONNECTIONROLE_NONE,
- dest->certificate_for_testing()
- ? rtc::SSLFingerprint::CreateFromCertificate(
- dest->certificate_for_testing())
- : nullptr);
+ remote_fingerprint.get());
std::string err;
SetLocalTransportDescription(transport_name, local_desc,
cricket::CA_OFFER, &err);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698